Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

bugfix/delete-undefined-sanity-key #4505

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

VWSCoronaDashboard26
Copy link
Contributor

@VWSCoronaDashboard26 VWSCoronaDashboard26 commented Nov 21, 2022

Summary

  • added new manual script to delete key
  • executed Sanity commands to delete rogue key which could have either caused Sanity studio to fail or cause the Sanity debugger to stop working properly

Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but this is a one off script specifically to delete keys pertaining to sprint 59?

If so, would it not make sense to make it more generic?

Also, is this executing on both development and production environments of sanity?

Copy link
Contributor

@APW26 APW26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to pre-approve this as I don't see anything wrong, but I did leave an earlier comment with a couple of questions.

@VWSCoronaDashboard26
Copy link
Contributor Author

Correct me if I'm wrong, but this is a one off script specifically to delete keys pertaining to sprint 59?

If so, would it not make sense to make it more generic?

You are correct, but I am not entirely sure if it would make sense to make this generic. We have several other folders containing files (going back as far as sprint 18) that do execute different one-off actions that were relevant to that sprint.

This script in particular deletes a single lokalize 'key' which actually did not have a key property (we are still not sure how this sprung into existence), so you could argue that it actually is no key.

Also, is this executing on both development and production environments of sanity?

I must admit that I am not 100% sure about this, though I have not seen or experienced any issues on the production environment of Sanity. Could you shine your light on this, @VWSCoronaDashboard19?

@APW26
Copy link
Contributor

APW26 commented Nov 21, 2022

You are correct, but I am not entirely sure if it would make sense to make this generic. We have several other folders containing files (going back as far as sprint 18) that do execute different one-off actions that were relevant to that sprint.

Hmm, do we need to have these files in the codebase in the long term? Seems a bit odd, personally, to have files/folders from previous sprints which would most likely not be used again? Perhaps this is something to discuss outside of this PR.

I must admit that I am not 100% sure about this, though I have not seen or experienced any issues on the production environment of Sanity. Could you shine your light on this, @VWSCoronaDashboard19?

Alright, but the key for which this PR was created existed in both the development and production datasets or just development?

@hasan-ozaynaci
Copy link
Contributor

Alright, but the key for which this PR was created existed in both the development and production datasets or just development?

It is only for development for this one.

@hasan-ozaynaci hasan-ozaynaci merged commit cf110b7 into develop Nov 21, 2022
@hasan-ozaynaci hasan-ozaynaci deleted the bugfix/delete-undefined-sanity-key branch November 21, 2022 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants