-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
… Sanity commands to delete rogue key;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but this is a one off script specifically to delete keys pertaining to sprint 59?
If so, would it not make sense to make it more generic?
Also, is this executing on both development and production environments of sanity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to pre-approve this as I don't see anything wrong, but I did leave an earlier comment with a couple of questions.
You are correct, but I am not entirely sure if it would make sense to make this generic. We have several other folders containing files (going back as far as sprint 18) that do execute different one-off actions that were relevant to that sprint. This script in particular deletes a single lokalize 'key' which actually did not have a
I must admit that I am not 100% sure about this, though I have not seen or experienced any issues on the production environment of Sanity. Could you shine your light on this, @VWSCoronaDashboard19? |
Hmm, do we need to have these files in the codebase in the long term? Seems a bit odd, personally, to have files/folders from previous sprints which would most likely not be used again? Perhaps this is something to discuss outside of this PR.
Alright, but the |
It is only for |
Summary