This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Set header and clean up old unused data on measures page in Sanity #4495
Merged
hasan-ozaynaci
merged 10 commits into
develop
from
feature/cor-1199-measures-page-adjustments
Nov 17, 2022
Merged
Set header and clean up old unused data on measures page in Sanity #4495
hasan-ozaynaci
merged 10 commits into
develop
from
feature/cor-1199-measures-page-adjustments
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasan-ozaynaci
requested review from
Jorrik-Klijnsma-Work and
VWSCoronaDashboard26
November 15, 2022 09:57
packages/app/src/domain/vaccine/components/age-group-select.tsx
Outdated
Show resolved
Hide resolved
APW26
reviewed
Nov 16, 2022
packages/app/src/pages/veiligheidsregio/[code]/geldende-adviezen.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/pages/veiligheidsregio/[code]/geldende-adviezen.tsx
Outdated
Show resolved
Hide resolved
VWSCoronaDashboard26
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a very small comment about something that might have simply be forgotten, but the code looks great! I appreciate the fact that you have drastically simplified some things! 🙌
hasan-ozaynaci
force-pushed
the
feature/cor-1199-measures-page-adjustments
branch
from
November 17, 2022 12:19
ab92ab8
to
17a36ed
Compare
hasan-ozaynaci
deleted the
feature/cor-1199-measures-page-adjustments
branch
November 17, 2022 17:42
VWSCoronaDashboard26
pushed a commit
that referenced
this pull request
Nov 18, 2022
…4495) * feat(measures): add consistent header with icon to page * feat(measures): Clean up old unused data on measures page in Sanity * fix: revert agegroup change * feat: updated logic for icons and Sanity * feat: cleanup code and optimize better naming * fix: removed redundant code as its already removed * fix: remove redundant code comment * feat: updated query for measuresItems * fix: fixed Sanity bug by filtering keyless docs * fix: cleaned up css formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary