Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Set header and clean up old unused data on measures page in Sanity #4495

Merged
merged 10 commits into from
Nov 17, 2022

Conversation

hasan-ozaynaci
Copy link
Contributor

@hasan-ozaynaci hasan-ozaynaci commented Nov 15, 2022

Summary

  • Add header with icon, category and title for measures page on VR and GM. So it is more consistent with the other page.
  • Get page content from Sanity now instead of static icon and title from lokalize.
  • Clean up old data and structure for measures page which were way outdated in Sanity.

  • BEFORE

jhi

  • AFTER

uyu

Copy link
Contributor

@VWSCoronaDashboard26 VWSCoronaDashboard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a very small comment about something that might have simply be forgotten, but the code looks great! I appreciate the fact that you have drastically simplified some things! 🙌

packages/app/src/pages/landelijk/geldende-adviezen.tsx Outdated Show resolved Hide resolved
@hasan-ozaynaci hasan-ozaynaci force-pushed the feature/cor-1199-measures-page-adjustments branch from ab92ab8 to 17a36ed Compare November 17, 2022 12:19
@hasan-ozaynaci hasan-ozaynaci merged commit da55787 into develop Nov 17, 2022
@hasan-ozaynaci hasan-ozaynaci deleted the feature/cor-1199-measures-page-adjustments branch November 17, 2022 17:42
VWSCoronaDashboard26 pushed a commit that referenced this pull request Nov 18, 2022
…4495)

* feat(measures): add consistent header with icon to page

* feat(measures): Clean up old unused data on measures page in Sanity

* fix: revert agegroup change

* feat: updated logic for icons and Sanity

* feat: cleanup code and optimize better naming

* fix: removed redundant code as its already removed

* fix: remove redundant code comment

* feat: updated query for measuresItems

* fix: fixed Sanity bug by filtering keyless docs

* fix: cleaned up css formatting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants