This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine (#4479) * fix(thermometer-timeline): fixes the logic which determines where to position the 'vandaag' label on the timeline. * fix(thermometer-timeline): revert data-structure.ts to its version on the develop branch * fix(thermometer-timeline): PR feedback * fix(thermometer-timeline): PR feedback - Add interface for timelineBarArrow, refactor and update logic for positioning 'vandaag' label. * fix(thermometer-timeline): PR feedback - rename variables * feat(thermometer-timeline): Implement a fix for when todays date is later than the last event in the timeline. * feat(thermometer-timeline): Remove todo comment
* FEAT: Sanity schema changes * feat: fix radio input floating around * feat: adding measurement tiles * feat: update current scheme's * FEAT: sanity schema's update * task: axtra changes * FEAT: findings of getting topical data and alements * Fixing non type import and exports * WIP * wip - working! * Link and icon update * feat: fixing small problems and typing of richtContentBlocks * feat(topical-page): reverted removal of timeline events from getElementsQuery functionality; * feat: pair programming session * feat: Pair programming session two * feat: solving all the PR feedback Co-authored-by: VWSCoronaDashboard26 <[email protected]>
* added metadataText to TopicalTile * feat(topical-tiles): fixed metadata naming * feat(topical-tiles): changed metadata to sourceLabel * feat(topical-tiles): added styling and cleaned up code based on code conventions * feat(topical-tiles): removed display block from Box component * Removed hardcoded data and used sanity data Co-authored-by: VWSCoronaDashboard21 <[email protected]> Co-authored-by: VWSCoronaDashboard18 <[email protected]>
* CHORES: common data build * CHORES: data-structure.ts from the cms updated
* fix: added extra subtitle field for topical page in Sanity * fix: add nullable type
hasan-ozaynaci
requested review from
Jorrik-Klijnsma-Work,
Amber-Taal-Work and
VWSCoronaDashboard26
November 10, 2022 13:50
Jorrik-Klijnsma-Work
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job! #19 and the rest
VWSCoronaDashboard26
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amber-Taal-Work
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.