Feature/cor 1159 collapsible thermometer description

[Jorrik-Klijnsma-Work]

Created the thermometer collapsible.
This is a new element and looks like this:

COLLAPSED

EXPANDED

[VWSCoronaDashboard26]

How about using a more semantic ol element here (in which each IndicatorLevelDescription component is represented by an li element with a value attrobite) instead of a generic div element (the default element used for a Box component)? The dropdown represents a list of items (severity levels) that are intentionally ordered (their order has impact on how severities are interpreted).

[VWSCoronaDashboard25]

I am a bit on the fence about this. The order we're showing these severity level descriptions in, is a human decision. The decision could also be(come): active level first, then the rest (in reverse order, why not?).
The levels could also become different. Now we have 3 which is worse than 2 but not as bad as 4. But what if they decide to get another level that's just as bad as 3, but in a different way?

I'd say safe ordered lists for natural orders such as sequential instructions, where the order is emphasised and use a ul instead. But that's just my opinion. I'll leave it to the developer.

Do make sure to test this properly on different browsers and systems though, because browsers add a number/bullet to lis natively, so making sure they don't show up in none of them can be tricky.

[Jorrik-Klijnsma-Work]

The first part of your question shows me it's the right thing to have it in an ordered list. Because as stated by you and previously the list has an order. And it's not random. It's the same every time, based on a human decision and executed manually. And not something unordered. And the part about sequential instructions? Who decides the order? It's a human decision, getting really abstract really fast.

The second part of your question: I agree testing is an important part of this list behaviour.

[VWSCoronaDashboard26]

I am a bit on the fence about this. The order we're showing these severity level descriptions in, is a human decision. The decision could also be(come): active level first, then the rest (in reverse order, why not?). The levels could also become different. Now we have 3 which is worse than 2 but not as bad as 4. But what if they decide to get another level that's just as bad as 3, but in a different way?

I'd say safe ordered lists for natural orders such as sequential instructions, where the order is emphasised and use a ul instead. But that's just my opinion. I'll leave it to the developer.

I get where you are coming from, but this is currently not supported by the implementation of the severity indicator. As of right now, it assumes there is a sequential order of severities based on what types are defined in code. If we would like to prepare for these potential changes like completely shuffling the order of severities (and possibly having the ability to do that on the fly) or having multiple severities of the same level but different, I agree that it would make sense to go with an unordered list as the order of severities could seem completely off (especially if an active severity is are sorted at the top, for example).

I mainly suggested using a semantic element over a div because we recently discussed to apply more semantic elements where possible.

[VWSCoronaDashboard25]

@VWSCoronaDashboard18

The first part of your question shows me it's the right thing to have it in an ordered list. Because as stated by you and previously the list has an order. And it's not random. It's the same every time, based on a human decision and executed manually. And not something unordered. And the part about sequential instructions? Who decides the order? It's a human decision, getting really abstract really fast.

My wording was maybe not on the spot, every website is formed on a human decision, so by continuing that logic in this manner, ul is obsolete and every list on a website should be a ol.

MDN has a nice hint that maybe can help to decide when to use an ol and when an ul

To determine which list to use, try changing the order of the list items; if the meaning changes, use the <ol> element — otherwise you can use <ul>.

In my opinion, changing the order doesn't change the meaning, because we have our own indicator inside that represents the severity level.

[VWSCoronaDashboard25]

@VWSCoronaDashboard26

I mainly suggested using a semantic element over a div because we recently discussed to apply more semantic elements where possible.

This, I fully support! I doubt though if we have forced our hand by the way it is coded, but it's fine either way. I just don't fully agree 😜

[VWSCoronaDashboard26]

On small comment on a remnant of a previous approach. Please have a look at the last comments.

[APW26]

Approved with one small non-blocking comment