COR-483 [1/2] Setup pre-commit hook for eslint+prettier #4445

VWSCoronaDashboard24 · 2022-10-05T13:34:05Z

Setup pre-commit hook for eslint + prettier
Cleanup dependencies
Update prettier
Moved all prettier related dependencies to the root package.json

Example:

A second PR will follow to format all the files according to the prettier config to prevent non-relevant whitespace changes in future commits.

Jorrik-Klijnsma-Work

Nice job!

hasan-ozaynaci

Great addition to this project, looks fine by me.

package.json

VWSCoronaDashboard24 added 4 commits October 5, 2022 14:48

chore(deps): update lint-staged, prettier

5bbedd2

feat(git-hooks): install lint-staged and cleanup dependencies

36ddda9

fix(lint-staged): use correct file types for lint-staged

c73e7e1

fix(deps): remove lint-staged from app package

c3992a9

VWSCoronaDashboard24 mentioned this pull request Oct 5, 2022

COR-483 [2/2] Format all files using Prettier #4446

Closed

VWSCoronaDashboard24 changed the title ~~COR-483 Setup pre-commit hook for eslint+prettier~~ COR-483 [1/2] Setup pre-commit hook for eslint+prettier Oct 5, 2022

VWSCoronaDashboard24 added 7 commits October 6, 2022 09:30

fix: lint-staged cleanup

ebb52df

fix: use correct eslint command

e9a94db

fix: use lint-staged in every workspace

feee7db

fix(prettier): set printWidth to 180

eb59dc8

fix(lint-staged): use global lint-staged config

4986fbb

fix(prettier): use printWidth of 180

8e37eb0

fix(eslint): ignore spec files

da481d9

Jorrik-Klijnsma-Work approved these changes Oct 6, 2022

View reviewed changes

hasan-ozaynaci approved these changes Oct 7, 2022

View reviewed changes

package.json Show resolved Hide resolved

VWSCoronaDashboard24 merged commit 7561e41 into develop Oct 10, 2022

VWSCoronaDashboard24 deleted the feature/COR-483-git-hooks branch October 10, 2022 06:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COR-483 [1/2] Setup pre-commit hook for eslint+prettier #4445

COR-483 [1/2] Setup pre-commit hook for eslint+prettier #4445

VWSCoronaDashboard24 commented Oct 5, 2022 •

edited

Loading

Jorrik-Klijnsma-Work left a comment

hasan-ozaynaci left a comment

COR-483 [1/2] Setup pre-commit hook for eslint+prettier #4445

COR-483 [1/2] Setup pre-commit hook for eslint+prettier #4445

Conversation

VWSCoronaDashboard24 commented Oct 5, 2022 • edited Loading

Jorrik-Klijnsma-Work left a comment

Choose a reason for hiding this comment

hasan-ozaynaci left a comment

Choose a reason for hiding this comment

VWSCoronaDashboard24 commented Oct 5, 2022 •

edited

Loading