This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Added Variant_code and order #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorrik-Klijnsma-Work
force-pushed
the
feature/COR-902-update-variant-with-order-and-variant-code
branch
from
30c3810 to
089d071
Compare
VWSCoronaDashboard25
previously requested changes
Jul 28, 2022
packages/app/src/domain/variants/static-props/get-variant-order-colors.ts
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/static-props/get-variant-order-colors.ts
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/static-props/get-variant-order-colors.ts
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/static-props/get-variant-table-data.ts
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/static-props/get-variant-order-colors.ts
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/static-props/get-variant-table-data.ts
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/variants-table-tile/components/variant-name-cell.tsx
Outdated
Show resolved
Hide resolved
Jorrik-Klijnsma-Work
requested review from
VWSCoronaDashboard25,
VWSCoronaDashboard26,
jeroen-drenth,
hasan-ozaynaci,
AwadMichael,
Amber-Taal-Work and
VWSCoronaDashboard24
packages/app/src/domain/variants/variants-stacked-area-tile/variants-stacked-area-tile.tsx
Outdated
Show resolved
Hide resolved
Jorrik-Klijnsma-Work
dismissed
VWSCoronaDashboard25’s stale review
Changes solved
packages/app/src/domain/variants/static-props/get-variant-order-colors.ts
Outdated
Show resolved
Hide resolved
packages/app/src/domain/variants/static-props/get-variant-chart-data.ts
Outdated
Show resolved
Hide resolved
…character variables
Jorrik-Klijnsma-Work
force-pushed
the
feature/COR-902-update-variant-with-order-and-variant-code
branch
from
85b81ed to
dad7c9c
Compare
VWSCoronaDashboard25
approved these changes
Aug 1, 2022
Jorrik-Klijnsma-Work
deleted the
feature/COR-902-update-variant-with-order-and-variant-code
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated variant graph and table to be compliant with backend data and set order based on backend input