Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Replace konva-node with konva #4335

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

hasan-ozaynaci
Copy link
Contributor

@hasan-ozaynaci hasan-ozaynaci commented Jul 25, 2022

This PR was reverted at release do to some warnings in the console. These do not occur anymore in this PR as the value is always present in the container

Remove deprecated dependancy konva-node and replace it with the one that is supported konva
See full conclusion of this fix

@hasan-ozaynaci hasan-ozaynaci changed the title feat: replace konva-node with konva Replace konva-node with konva Jul 25, 2022
Copy link
Contributor

@VWSCoronaDashboard24 VWSCoronaDashboard24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. The former runtime errors are now gone. 👍

@hasan-ozaynaci hasan-ozaynaci merged commit dd6d730 into develop Jul 28, 2022
@hasan-ozaynaci hasan-ozaynaci deleted the feature/remove-konva-node branch July 28, 2022 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants