Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

COR-754 | Proposal: dynamic loading of Sanity keys in debug mode #4328

Merged
merged 11 commits into from
Aug 2, 2022

Conversation

VWSCoronaDashboard24
Copy link
Contributor

@VWSCoronaDashboard24 VWSCoronaDashboard24 commented Jul 21, 2022

Goal of this PR: show as much Sanity keys as possible when debug toggle is set to "keys".

Introduced in this PR:

  • useDynamicLokalizeTexts hook to dynamically load Sanity content (client side)
  • "selector" concept for Sanity texts: selectLokalizeTexts. Which is a function that "selects" certain parts of the Sanity texts which are used on the dedicated page.

Currently this change is only visible on the "Actueel" page. A future PR will come to apply this change to all other pages as well.

Before (with debug toggle set to "keys"):
Screenshot 2022-07-21 at 13 02 48

State with the changes of this PR:

Screenshot 2022-07-21 at 13 04 25

Screenshot 2022-07-21 at 13 04 36

@VWSCoronaDashboard24 VWSCoronaDashboard24 marked this pull request as ready for review July 21, 2022 11:10
@VWSCoronaDashboard24 VWSCoronaDashboard24 changed the title Bugfix/cor 754 sanity keys COR-754 | Proposal: dynamic loading of Sanity keys in debug mode Jul 21, 2022
@VWSCoronaDashboard24 VWSCoronaDashboard24 merged commit 2ae23bc into develop Aug 2, 2022
@VWSCoronaDashboard24 VWSCoronaDashboard24 deleted the bugfix/COR-754-sanity-keys branch August 2, 2022 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants