This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Release/2.51.3 #4317
Merged
Release/2.51.3 #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…covers all scenario's (removes occasional January 1st 1970 from the pages) (#4314) Also removed some entries as 'pageMetrics' that are backend data, but no page metrics, e.g. 'code' and 'static_values.<anything>' Co-authored-by: VWSCoronaDashboard25 <[email protected]>
* feat: updated CovidVariantenPage page component to update layout. updated VariantNameCell component to have a hover state configurable through props. updated getVariantTableData functionality to filter out irrelevant variants and map colors between graphs and tables. * feat: updated PercentageBar component to correctly render the background color. * feat: updated getVariantTableData functionality to 1) filter out 'other_graph' variants; 2) create a mapped sorting of variants based on the Greek alphabet; 3) correctly map colors for the 'other_table' variant; 4) simplify the final array filtering * feat: small consistency fix * feat: updated VariantNameCell component to rename hasHoverState to isTooltipEnabled; updated getVariantTableData functionality to restore filtering based on historical significance * feat: reverted strict mapping between Greek alphabet and variants; removed TODO code; 'fixed' percentage mapping; 'fixed' color and order mapping * feat: revert back to commit 0c0083d with changes applied * feat: removed TODO; fixed comments * feat: removed TODO; fixed comments * feat: fix linting issues * feat: update variant sorting algorithm with dedicated util method to always sort variants not in the map (omicron sub-variants for instance) to the back of the list; * feat: updated colors so that they are in the correct order; * feat: updated types for the different new omicron sub-variants (leveraging _-notation rather than .-notation); introduced temporary testing colors; * feat: updated colors; started on the variants chart; * chore: add Sanity keys for omicron variants * feat: updated useSeriesConfig hook in VariantStackedAreaTileWithData component to properly handle new sub-variant names for the chart (i.e. omicron ba_2_12_1_percentage); * feat: updated graph to remove 'other_graph' variants from the graph; updated chart to add date below the chart; * feat: updated InteractiveLegend component to add a new GappedArea component to match with the chart appearance in regards to how data series and tooltip indicators are rendered; * feat: updated getVariantTableData functionality to sort based on reversed Greek alphabet; did some prep-work for PR #4314 * feat: updated VariantsStackedAreaTile component to pass correct properties to metadata prop; * feat: updated TooltipList styles to only use two columns when on certain breakpoints; updated TooltipContent styles to increase the maxWidth of the component; Co-authored-by: VWSCoronaDashboard26 <[email protected]> Co-authored-by: VWSCoronaDashboard25 <[email protected]>
VWSCoronaDashboard26
approved these changes
Jul 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for one specific order of variants with the same first date of occurrence.