This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored axes component * Lint fixes * Removed number as T extend * Removed redundant prop * Code optimalization
* chore: update styled-components and friends * chore: update typescript for app * chore: update typescript for cli * chore: update ts-node, sanity, typescript * fix: fall back to variantName in json when not provided in sanity * chore: audit fix * restore data-structure Co-authored-by: VWSCoronaDashboard24 <[email protected]>
* fix: remove minHeight for vr and gm pages choropleth * fix: only set minHeight when provided * fix: remove console.log * fix: code cleanup Co-authored-by: VWSCoronaDashboard24 <[email protected]>
- Align label next to top axis-left tick value - Align top axis left tick value with chart line - Some code formatting
* feat: scroll through list of results with keyboard * feat: Add guard pattern and named functions - Change if statement and add guard - Add extra comment for specific calculations - Change functions to named functions * feat: rename function according to coding standards
* feat: show sanity debug toggle also ons taging * fix: revert code change * fix: revert code change Co-authored-by: VWSCoronaDashboard24 <[email protected]>
The graph was unarchived but still pointed to the archived dataset. This commit fixes that. And properly removes it from other calculations as well. Co-authored-by: VWSCoronaDashboard25 <[email protected]>
Prevents a potential runtime error since #4292 by returning empty x-axis labels if the graph has no values. Co-authored-by: VWSCoronaDashboard25 <[email protected]>
* Removed empty tile * Removed unused import * Removed prop and type
jeroen-drenth
requested review from
VWSCoronaDashboard25 and
VWSCoronaDashboard26
July 6, 2022 13:55
VWSCoronaDashboard25
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😁
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.