Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Commit

Permalink
fix: set OS and NodeJS version to use in GitHub workflow (#4945)
Browse files Browse the repository at this point in the history
* fix: set version hard

* fix: set version hardcoded on all other workflow files

* fix: node

* fix: add matrix to all jobs

* fix: add use node 18.18.2

* fix: Remove unused use-node 18.18.2

* fix: Set ubuntu version to 22.04 and node version to 18.18.2

* fix: remove Os
  • Loading branch information
ben-van-eekelen authored Dec 11, 2023
1 parent 6da6b85 commit d4f2d3b
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 10 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:
jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
permissions:
actions: read
contents: read
Expand All @@ -32,6 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [ 18.18.2 ]
language: ['javascript']
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
# Learn more:
Expand All @@ -41,6 +42,11 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/infra-acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
trigger-acceptance-build:
environment: Acceptance
name: Call Azure Pipeline
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Azure Pipelines Action
uses: Azure/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/infra-develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
trigger-develop-build:
environment: Development
name: Call Azure Pipeline
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Azure Pipelines Action
uses: Azure/pipelines@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/infra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
build:
name: Call Azure Pipeline
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Azure Pipelines Action
uses: Azure/pipelines@v1
Expand Down
34 changes: 29 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,28 @@ on: pull_request

jobs:
init:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Cancel previous workflow
uses: styfle/[email protected]
with:
access_token: ${{ github.token }}

lint:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
node-version: [18.18.2]
needs: init
steps:
- name: Check out repository
uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
Expand All @@ -38,7 +46,10 @@ jobs:
run: yarn lint

compile:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
node-version: [18.18.2]
needs: init
steps:
- name: Get target branch name (pull request)
Expand All @@ -49,6 +60,11 @@ jobs:
- name: Check out repository
uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
Expand Down Expand Up @@ -83,12 +99,20 @@ jobs:
run: yarn typecheck

test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
node-version: [18.18.2]
needs: init
steps:
- name: Check out repository
uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
Expand Down Expand Up @@ -118,7 +142,7 @@ jobs:
run: yarn test:ci

docker:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: init
if: contains(github.head_ref, 'release')
steps:
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/sync-sanity-lokalize.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,19 @@ on:

jobs:
sync-after-feature:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
node-version: [18.18.2]
steps:
- name: Check out repository
uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn config get cacheFolder)"
Expand Down

0 comments on commit d4f2d3b

Please sign in to comment.