Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!(template): correct profile photo import logic #43

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

mintyfrankie
Copy link
Owner

Fix #42

BREAKING CHANGES

  • due to Typst path handling mecanism, the current implementation for importing profile photo is broken.
  • a hotfix is to be patched to import the image function at cv.typ level instead of metadata.toml
  • this fix is not ideal, and will be reverted/changed once Typst introduces better solution

BREAKING CHANGES
- due to Typst path handling mecanism, the current implementation for importing profile photo is broken.
- a hotfix is to be patched to import the image function at cv.typ level instead of metadata.toml
- this fix is not ideal, and will be reverted/changed once Typst introduces better solution
@mintyfrankie mintyfrankie self-assigned this Jul 26, 2024
@mintyfrankie mintyfrankie merged commit 37cfd7e into main Jul 26, 2024
2 checks passed
@mintyfrankie mintyfrankie deleted the fix-profilePhoto branch July 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

profile_photo_path in metadata.toml cannot be well parsed
1 participant