LSP: Fix enum destructuring/id linking to other types with the same name

[jansul]

Noticed a bug when working on a fix for the issue mentioned in my last PR.

When doing "Go to Definition" on an Ast::EnumId or Ast::EnumDestructuring node, if their .option field matched the name of an existing component, store etc, then it would link to that instead.

Here's an example of the issue in video form:

2023-08-19.12-05-20.mp4

The fix here was to stop tracking Ast::TypeId within these two nodes, as hover/definition etc use the higher level nodes to provide their features anyway.

[gdotdesign]

The fix here was to stop tracking Ast::TypeId within these two nodes, as hover/definition etc use the higher level nodes to provide their features anyway.

Would this mean that the options are not linkable themselves, just the enum itself?

[jansul]

Would this mean that the options are not linkable themselves, just the enum itself?

That still works thanks to the use of cursor_intersects? within the enum_id definition file.

In hindsight we might not actually need that method, instead just looking through the stack as we do for module access.. But possible one for another refactoring 🙈

[gdotdesign]

That still works thanks to the use of cursor_intersects? within the enum_id definition file.

Ah yeah, that was what I was missing :)