-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and Gameplay Changes #87
Merged
CovenEsme
merged 53 commits into
mint-choc-chip-skyblade:main
from
CovenEsme:misc-fixes
Nov 16, 2023
Merged
Fixes and Gameplay Changes #87
CovenEsme
merged 53 commits into
mint-choc-chip-skyblade:main
from
CovenEsme:misc-fixes
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a whole bunch of bugs and makes several changes to improve the quality and general flow of the rando. Changes include:
Added/Changed:
Skipper's Retreat - Skydive Chest
Removed:
Knight Academy - Item from Cawlin
Shipyard - Rickety Coaster
Fixed:
Sealed Grounds - Gorko's Goddess Wall
)How do you test this changes?
All of these are either asm changes or stage/eventpatches and can be tested individually. I've been through each point a few times but some of them will probably need to be revisited.
Notes
There's a lot in this and stuff should have been split into several PRs. This should be almost all of the "small" changes that I want to make from SDR and fix almost all of the currently known bugs.