Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Gameplay Changes #87

Merged
merged 53 commits into from
Nov 16, 2023

Conversation

CovenEsme
Copy link
Contributor

What does this PR do?

Fixes a whole bunch of bugs and makes several changes to improve the quality and general flow of the rando. Changes include:

Added/Changed:

  • Add anti-softlock bomb flower next to Skipper's Retreat - Skydive Chest
  • Add missed ammo pot to bird statue near the Construction Bay in Shipyard
  • Always spawn the Groosenator (fixes a crash and will be actually used in the future)
  • Spawn tornados further away (to account for the increased loftwing speed)

Removed:

  • Remove Harp + Toilet Hand requirement for Knight Academy - Item from Cawlin
  • Remove Moldarach 2 requirement for Shipyard - Rickety Coaster
  • Remove the Chuchu where you pick up Guld in Mogma Turf
  • Remove cutscene of Pipit scolding Mallara
  • Remove Impa cutscene in Eldin
  • Remove waterfall sounds outside the Ancient Cistern dungeon entrance
  • Remove first time textboxes for treasures and insects
  • Remove textboxes when picking up certain items/actors
    • LMF conveyor stamina fruits
    • Shot single arrows
    • Lizalfos Tails
    • Heart flowers
    • Treasures
    • Insects

Fixed:

  • Fix underwater item gets
  • Fix Spiral Charge item get animation
  • Fix Goddess Sword not appearing in the Goddess Statue pedestal
  • Fix Goddess Statue entrance
  • Fix Goddess Walls and Blessed Butterfly spawns (fixes Sealed Grounds - Gorko's Goddess Wall)
  • Fix Harp giving the Temple of Time bird statue
  • Fix Harp + Ballad (storyflag 13) from giving the inner FS bird statue
  • Fix sometimes not being able to talk to Bucha when you have the Slingshot
  • Fix upper Eldin extending bridge
  • Fix several item y-offsets
  • Fix several individual crystal check's heights and rotations
  • Minor fixes to several NPCs
    • Make Pipit spawn outside the Knight Academy at night
    • Make Orielle spawn on Skyloft or in her house only after you've saved her and her bird
    • Fix the Attention Mark for Cawlin
    • Add an Attention Mark for the minecart minigame Goron

How do you test this changes?

All of these are either asm changes or stage/eventpatches and can be tested individually. I've been through each point a few times but some of them will probably need to be revisited.

Notes

There's a lot in this and stuff should have been split into several PRs. This should be almost all of the "small" changes that I want to make from SDR and fix almost all of the currently known bugs.

@CovenEsme CovenEsme changed the title Misc fixes Fixes and Gameplay Changes Nov 16, 2023
@CovenEsme CovenEsme merged commit 435792c into mint-choc-chip-skyblade:main Nov 16, 2023
1 check passed
@CovenEsme CovenEsme deleted the misc-fixes branch November 16, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant