Fix incorrect time of day logic for the Bazaar #434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this address?
Fixes the issue where the randomizer believed that the nighttime state could be carried through the Bazaar.
Also fixes a missed case when reading entrances from plando files
How did/do you test these changes?
I used a plandomizer file to bind the after waterfall cave entrance to one of the Bazaar entrances:
Before the fix, this was valid and the randomizer accepted this input. After the fix, the randomizer throws the following error (truncated for readability):