Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect time of day logic for the Bazaar #434

Merged

Conversation

CovenEsme
Copy link
Contributor

What does this address?

Fixes the issue where the randomizer believed that the nighttime state could be carried through the Bazaar.

Also fixes a missed case when reading entrances from plando files

How did/do you test these changes?

I used a plandomizer file to bind the after waterfall cave entrance to one of the Bazaar entrances:

World 1:
  entrances:
    Waterfall Cave -> Skyloft Past Waterfall Cave: Central Skyloft from Bazaar North

Before the fix, this was valid and the randomizer accepted this input. After the fix, the randomizer throws the following error (truncated for readability):

Shuffling entrances for World 1...
Missing locations:
 ['Central Skyloft - Crystal after Waterfall Cave', 'Central Skyloft - Crystal in Loftwing Prison']
Traceback (most recent call last):
...
logic.entrance_shuffle.EntranceShuffleError: Not all logic is satisfied!

@CovenEsme
Copy link
Contributor Author

Oh yeah, this test fails atm. It's that issue with the decoupled entrances test which is fixed in #433. I didn't think this PR would run into that issue but I guess the change in the logic files was sufficient to trigger it.

I guess merge #433 first :p

@CovenEsme
Copy link
Contributor Author

Cool, just pulled in #433. The tests should pass in a couple of minutes xDD

@CovenEsme CovenEsme merged commit 90878b6 into mint-choc-chip-skyblade:main Dec 4, 2024
1 check passed
@CovenEsme CovenEsme deleted the fix-bazaar-tod-logic branch December 4, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants