move fflush to a thread #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflush can block if buffers are full include regression test for large output
gidim
reviewed
May 10, 2018
| libc.fflush(c_stderr_p) | ||
| r, w, x = select.select(pipes, [], [], self.flush_interval) | ||
| if not r: | ||
| r, w, x = select.select(pipes, [], [], flush_interval) |
There was a problem hiding this comment.
Why did you changeself.flush_interval to flush_interval?
There was a problem hiding this comment.
Because now it may be self._flush_interval or 0 depending on the previous state.
avoids blocking the reader thread in a call to fflush on the writer pipe, which will only unblock when the reader is finished
minrk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fflush can block if buffers are full
include regression test for large output
closes #15