Preparation to add tags to secrets #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 30, 2024 15:58
into their own files for ease of identification. Each secret has AWS resource tags added and a description. The description is necessary as the secrets name follows the original convention from their place in AWS SSM Parameter store, which doesn't indicate clearly their purpose or use in certain cases. The locals have been moved to the locals.tf
The metadata changes (description and tags) have been commented out pending the investigation and work on the data block for data "aws_secretsmanager_secret_version" which is triggering a RDS DB rebuild. This code establishes a cleaner layout by separating the secrets into their service groupings and have the metadata attributes ready to use. ND-505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated the DNS, DHCP and Admin secrets into their own files for ease of identification.
Each secret has AWS resource tags added and a description.
The description is necessary as the secrets name follows the original convention from their place in AWS SSM Parameter store, which doesn't indicate clearly their purpose or use in certain cases.
The locals have been moved to the locals.tf
Commented out metadata changes
The metadata changes (description and tags) have been commented out pending the investigation and work on the data block for
data "aws_secretsmanager_secret_version" which is triggering a RDS DB rebuild.
This code establishes a cleaner layout by separating the secrets into their service groupings and have the metadata attributes ready to use.
ND-505