Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nd174 secrets accessible in plain text #321

Merged
merged 10 commits into from
May 30, 2024

Conversation

asifamirat00
Copy link
Contributor

ND-174 secrets accessible in plain text

@asifamirat00 asifamirat00 requested a review from a team as a code owner May 28, 2024 08:16
…id from locals doing the data lookup directly withing each secret which is much cleaner - applying to all secrets ND-174
@asifamirat00 asifamirat00 force-pushed the feature/nd174-secrets-accessible-in-plain-text branch from a906bab to e90c407 Compare May 28, 2024 17:44
Copy link
Contributor

@juddin927 juddin927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jamesgreen-moj jamesgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/admin/iam.tf Outdated Show resolved Hide resolved
…icy as we should not be granting full access
@asifamirat00 asifamirat00 force-pushed the feature/nd174-secrets-accessible-in-plain-text branch from 8e56cb2 to 3c57376 Compare May 29, 2024 15:30
Copy link
Contributor

@jamesgreen-moj jamesgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asifamirat00 asifamirat00 merged commit 5974872 into main May 30, 2024
@asifamirat00 asifamirat00 deleted the feature/nd174-secrets-accessible-in-plain-text branch May 30, 2024 08:51
@asifamirat00 asifamirat00 restored the feature/nd174-secrets-accessible-in-plain-text branch May 30, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants