generated from ministryofjustice/cloud-platform-terraform-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nd174 secrets accessible in plain text #321
Merged
asifamirat00
merged 10 commits into
main
from
feature/nd174-secrets-accessible-in-plain-text
May 30, 2024
Merged
Feature/nd174 secrets accessible in plain text #321
asifamirat00
merged 10 commits into
main
from
feature/nd174-secrets-accessible-in-plain-text
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…task definitions ND-174
…smaccess to execution iam role
…id from locals doing the data lookup directly withing each secret which is much cleaner - applying to all secrets ND-174
asifamirat00
force-pushed
the
feature/nd174-secrets-accessible-in-plain-text
branch
from
May 28, 2024 17:44
a906bab
to
e90c407
Compare
juddin927
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jamesgreen-moj
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jamesgreen-moj
requested changes
May 29, 2024
…icy as we should not be granting full access
asifamirat00
force-pushed
the
feature/nd174-secrets-accessible-in-plain-text
branch
from
May 29, 2024 15:30
8e56cb2
to
3c57376
Compare
jamesgreen-moj
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ND-174 secrets accessible in plain text