Fix connection and public IP issues and add documentation. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2024 17:33
Bastions now have no public ip associted with them. Have the vpc endpoints security group added. Additional outputs for referencing the security groups and details for engineers to confirm values related to the VPCs and DBs.
github-actions
bot
added
documentation
| echo $ENV | ||
|
|
||
|
|
||
| ### rds_servers_bastion |
There was a problem hiding this comment.
Can these comments be removed?
There was a problem hiding this comment.
No as the script is there to be used ad-hoc, we could create a more comprehensive script that captured the use case of updating and retrieving but it doesn't warrant the effort.
jamesgreen-moj
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of the NACs RDS Bastion feature, it was noted that this implementation had some issues.
associate_public_ip_address | this was incorrectly set.
security_group_ids | the VPC endpoinst security group had been omitted.
ssm_session_manager_endpoints | for the services required some logic as they are shared with the load testing bastion.
In order to create an easy engineer experience some additional outputs have been added for consistency across the two projects.
The documentation has been added.