Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional nat gateway #295

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Additional nat gateway #295

merged 2 commits into from
Oct 24, 2023

Conversation

jamesgreen-moj
Copy link
Contributor

  • Route table updated to point at correct NAT Gateway, for the correct AZ
  • Added import to make file

@jamesgreen-moj
Added import to makefile
92ec751 
I want to be able to import resources into state, so I have added this
to the make file
@jamesgreen-moj jamesgreen-moj requested a review from a team as a code owner October 23, 2023 15:57
@jamesgreen-moj jamesgreen-moj mentioned this pull request Oct 23, 2023
Closed
smjmoj
smjmoj suggested changes Oct 23, 2023
View reviewed changes
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM
Requires spelling amendments

@jamesgreen-moj
Updated NAT Gateway AZ
6407d6c 
Updated the NatGateway Route table for DNS, so it can use both
eu-west-2a and eu-west-2b.
smjmoj
smjmoj approved these changes Oct 24, 2023
View reviewed changes
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM

@smjmoj smjmoj merged commit c0d7e08 into main Oct 24, 2023
2 of 3 checks passed
@smjmoj smjmoj deleted the additional-nat-gateway branch October 24, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smjmoj smjmoj smjmoj approved these changes

@darey-io darey-io Awaiting requested review from darey-io darey-io is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@staff-infrastructure-moj staff-infrastructure-moj Awaiting requested review from staff-infrastructure-moj staff-infrastructure-moj is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@juddin927 juddin927 Awaiting requested review from juddin927 juddin927 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
dhcp-dns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesgreen-moj @smjmoj