Skip to content

Commit

Permalink
reverted the coresham test instruction
Browse files Browse the repository at this point in the history
  • Loading branch information
laurentb4 committed Oct 11, 2024
1 parent c94b0ec commit 91441c1
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 18 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ endif
$(MAKE) -init
.PHONY: -init
-init: ## terraform init (make init ENV=development)
-init:
$(DOCKER_RUN) terraform init --backend-config="key=terraform.$$ENV.state"
$(MAKE) workspace-select
Expand Down
11 changes: 0 additions & 11 deletions data.tf
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,6 @@ data "aws_ssm_parameter" "pdns_ips_list" {
with_decryption = true
}

# I DONT THINK THIS ONE IS NEEDED
# data "aws_ssm_parameter" "critical_notification_recipients" {
# name = "codebuild/pttp-ci-infrastructure-core-pipeline/${terraform.workspace}/critical_notification_recipients"
# }

data "aws_ssm_parameter" "vpn_hosted_zone_id" {
name = "/codebuild/${terraform.workspace}/vpn_hosted_zone_id"
with_decryption = true
Expand Down Expand Up @@ -151,12 +146,6 @@ data "aws_ssm_parameter" "model_office_vm_ip" {
with_decryption = true
}

# I DONT THINK THIS ONE IS NEEDED - it's not used anywhere
# data "aws_ssm_parameter" "dhcp_egress_transit_gateway_routes" {
# name = "/staff-device/${terraform.workspace}/dhcp_egress_transit_gateway_routes"
# with_decryption = true
# }

data "aws_ssm_parameter" "allowed_ip_ranges" {
name = "/staff-device/dns-dhcp/admin/${terraform.workspace}/allowed_ip_ranges"
}
Expand Down
2 changes: 1 addition & 1 deletion documentation/corsham-test.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ This is integrated with the production MoJ network so will only work on our prod

1. Add your public IP address to AWS SSM parameter store (Shared Services Account) `/staff-device/corsham_testing/bastion_allowed_ingress_ip`.

2. Modify the `/staff-device/dns-dhcp/$ENV/enable_bastion` ssm parameter in AWS shared services account and set it to `true`.
2. Modify the `enable_corsham_test_bastion` variable in `./variables.tf` and set it to `true`.

3. Run the pipeline.

Expand Down
5 changes: 0 additions & 5 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ variable "enable_critical_notifications" {
default = false
}

variable "critical_notification_recipients" {
type = list(any)
default = []
}

variable "admin_db_backup_retention_period" {
type = number
default = 30
Expand Down

0 comments on commit 91441c1

Please sign in to comment.