-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLPAB-2692: Allow changing details after a failed vouch #1694
Merged
acsauk
merged 15 commits into
main
from
MLPAB-2692-prevent-donor-details-update-during-pending-id
Jan 7, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
422d023
MLPAB-2692 allow changing details after a failed vouch
acsauk 764b796
MLPAB-2692 relax conditions around Completed
acsauk 99763b2
MLPAB-2692 fix template logic
acsauk 82b06db
MLPAB-2692 Merge branch 'main' into MLPAB-2692-prevent-donor-details-…
acsauk 2eac74d
MLPAB-2692 more template logic fixes
acsauk da26759
MLPAB-2692 Merge branch 'main' into MLPAB-2692-prevent-donor-details-…
acsauk d2e26aa
MLPAB-2692 fix e2e
acsauk 606ea1f
MLPAB-2692 Merge branch 'main' into MLPAB-2692-prevent-donor-details-…
acsauk f5493d2
MLPAB-2692 replace CanChange checks with SignedAt.IsZero checks
acsauk f627809
MLPAB-2692 centralise canChangePersonalDetails logic in Provided
acsauk e4a7a13
MLPAB-2692 use VoucherInvitedAt to determine if vouch in progress
acsauk 40a1cf6
MLPAB-2692 Merge branch 'main' into MLPAB-2692-prevent-donor-details-…
acsauk d29693f
MLPAB-2692 reinstate CanChange
acsauk cf7dda2
MLPAB-2692 allow going to name and dob
acsauk 33a63b4
MLPAB-2692 Merge branch 'main' into MLPAB-2692-prevent-donor-details-…
acsauk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{"cypress/e2e/accessibility/data-loss-warning.cy.js":{"time":2779,"weight":4},"cypress/e2e/attorney/confirm-your-details.cy.js":{"time":1488,"weight":2},"cypress/e2e/attorney/language-preferences.cy.js":{"time":2843,"weight":5},"cypress/e2e/attorney/legal-rights-and-responsibilities.cy.js":{"time":738,"weight":1},"cypress/e2e/attorney/opt-out.cy.js":{"time":1771,"weight":3},"cypress/e2e/attorney/phone-number.cy.js":{"time":2083,"weight":3},"cypress/e2e/attorney/progress.cy.js":{"time":3098,"weight":5},"cypress/e2e/attorney/read-the-lpa.cy.js":{"time":904,"weight":1},"cypress/e2e/attorney/sign.cy.js":{"time":3874,"weight":6},"cypress/e2e/attorney/start.cy.js":{"time":244,"weight":0},"cypress/e2e/attorney/task-list.cy.js":{"time":836,"weight":1},"cypress/e2e/attorney/trust-corporation.cy.js":{"time":12475,"weight":22},"cypress/e2e/attorney/what-happens-when-you-sign-the-lpa.cy.js":{"time":1220,"weight":2},"cypress/e2e/certificate-provider/certificate-provided.cy.js":{"time":2216,"weight":3},"cypress/e2e/certificate-provider/choose-not-to-be-a-certificate-provider.cy.js":{"time":2303,"weight":4},"cypress/e2e/certificate-provider/confirm-your-details.cy.js":{"time":4781,"weight":8},"cypress/e2e/certificate-provider/confirm-your-identity.cy.js":{"time":5471,"weight":9},"cypress/e2e/certificate-provider/enter-date-of-birth.cy.js":{"time":6964,"weight":12},"cypress/e2e/certificate-provider/enter-reference-number.cy.js":{"time":4311,"weight":7},"cypress/e2e/certificate-provider/language-preferences.cy.js":{"time":2183,"weight":3},"cypress/e2e/certificate-provider/provide-certificate.cy.js":{"time":2456,"weight":4},"cypress/e2e/certificate-provider/read-the-lpa.cy.js":{"time":1617,"weight":2},"cypress/e2e/certificate-provider/start.cy.js":{"time":333,"weight":0},"cypress/e2e/certificate-provider/task-list.cy.js":{"time":670,"weight":1},"cypress/e2e/certificate-provider/what-is-your-home-address.cy.js":{"time":8871,"weight":15},"cypress/e2e/certificate-provider/who-is-eligible.cy.js":{"time":759,"weight":1},"cypress/e2e/dev-features.cy.js":{"time":320,"weight":0},"cypress/e2e/donor/add-correspondent.cy.js":{"time":6344,"weight":11},"cypress/e2e/donor/can-you-sign-your-lpa.cy.js":{"time":1002,"weight":1},"cypress/e2e/donor/certificate-provider.cy.js":{"time":16909,"weight":30},"cypress/e2e/donor/check-your-details.cy.js":{"time":2589,"weight":4},"cypress/e2e/donor/check-your-lpa.cy.js":{"time":10535,"weight":18},"cypress/e2e/donor/choose-attorneys-address.cy.js":{"time":10026,"weight":17},"cypress/e2e/donor/choose-attorneys-summary.cy.js":{"time":7724,"weight":13},"cypress/e2e/donor/choose-attorneys-task.cy.js":{"time":16572,"weight":29},"cypress/e2e/donor/choose-attorneys.cy.js":{"time":10799,"weight":19},"cypress/e2e/donor/choose-people-to-notify-address.cy.js":{"time":4323,"weight":7},"cypress/e2e/donor/choose-replacement-attorneys-address.cy.js":{"time":8581,"weight":15},"cypress/e2e/donor/choose-replacement-attorneys-summary.cy.js":{"time":7142,"weight":12},"cypress/e2e/donor/choose-replacement-attorneys-task.cy.js":{"time":110110,"weight":197},"cypress/e2e/donor/choose-replacement-attorneys.cy.js":{"time":12156,"weight":21},"cypress/e2e/donor/confirm-person-allowed-to-vouch.cy.js":{"time":3787,"weight":6},"cypress/e2e/donor/confirm-your-certificate-provider-is-not-related.cy.js":{"time":2370,"weight":4},"cypress/e2e/donor/confirm-your-identity-and-sign.cy.js":{"time":19599,"weight":35},"cypress/e2e/donor/dashboard.cy.js":{"time":5604,"weight":10},"cypress/e2e/donor/delete-lpa.cy.js":{"time":2573,"weight":4},"cypress/e2e/donor/enter-access-code.cy.js":{"time":1133,"weight":2},"cypress/e2e/donor/enter-replacement-trust-corporation-address.cy.js":{"time":9543,"weight":17},"cypress/e2e/donor/enter-replacement-trust-corporation.cy.js":{"time":2787,"weight":4},"cypress/e2e/donor/enter-trust-corporation-address.cy.js":{"time":9941,"weight":17},"cypress/e2e/donor/enter-trust-corporation.cy.js":{"time":2438,"weight":4},"cypress/e2e/donor/enter-voucher.cy.js":{"time":3405,"weight":6},"cypress/e2e/donor/how-should-attorneys-make-decisions.cy.js":{"time":3124,"weight":5},"cypress/e2e/donor/how-should-replacement-attorneys-make-decisions.cy.js":{"time":2809,"weight":5},"cypress/e2e/donor/how-should-replacement-attorneys-step-in.cy.js":{"time":2299,"weight":4},"cypress/e2e/donor/language-preferences.cy.js":{"time":937,"weight":1},"cypress/e2e/donor/life-sustaining-treatment.cy.js":{"time":1509,"weight":2},"cypress/e2e/donor/lpa-progress.cy.js":{"time":2331,"weight":4},"cypress/e2e/donor/lpa-type.cy.js":{"time":3416,"weight":6},"cypress/e2e/donor/make-a-new-lpa.cy.js":{"time":4946,"weight":8},"cypress/e2e/donor/payment.cy.js":{"time":24859,"weight":44},"cypress/e2e/donor/people-to-notify.cy.js":{"time":10220,"weight":18},"cypress/e2e/donor/previous-application-number.cy.js":{"time":2086,"weight":3},"cypress/e2e/donor/provide-your-details.cy.js":{"time":4771,"weight":8},"cypress/e2e/donor/remove-replacement-trust-corporation.cy.js":{"time":1170,"weight":2},"cypress/e2e/donor/remove-trust-corporation.cy.js":{"time":1118,"weight":2},"cypress/e2e/donor/restrictions.cy.js":{"time":758,"weight":1},"cypress/e2e/donor/signing-on-behalf.cy.js":{"time":3791,"weight":6},"cypress/e2e/donor/start.cy.js":{"time":525,"weight":0},"cypress/e2e/donor/task-list.cy.js":{"time":388,"weight":0},"cypress/e2e/donor/want-replacement-attorneys.cy.js":{"time":3117,"weight":5},"cypress/e2e/donor/what-is-vouching.cy.js":{"time":645,"weight":1},"cypress/e2e/donor/what-you-can-do-now.cy.js":{"time":7979,"weight":14},"cypress/e2e/donor/when-can-the-lpa-be-used.cy.js":{"time":1341,"weight":2},"cypress/e2e/donor/withdraw-lpa.cy.js":{"time":1309,"weight":2},"cypress/e2e/donor/you-cannot-sign-your-lpa-yet.cy.js":{"time":3047,"weight":5},"cypress/e2e/donor/your-address.cy.js":{"time":8367,"weight":14},"cypress/e2e/donor/your-authorised-signatory.cy.js":{"time":2151,"weight":3},"cypress/e2e/donor/your-date-of-birth.cy.js":{"time":4491,"weight":8},"cypress/e2e/donor/your-independent-witness-address.cy.js":{"time":10224,"weight":18},"cypress/e2e/donor/your-independent-witness-mobile.cy.js":{"time":2077,"weight":3},"cypress/e2e/donor/your-independent-witness.cy.js":{"time":2018,"weight":3},"cypress/e2e/donor/your-name.cy.js":{"time":2438,"weight":4},"cypress/e2e/error-pages.cy.js":{"time":1334,"weight":2},"cypress/e2e/navigation.cy.js":{"time":801,"weight":1},"cypress/e2e/supporter/add-correspondent.cy.js":{"time":13377,"weight":23},"cypress/e2e/supporter/dashboard.cy.js":{"time":12647,"weight":22},"cypress/e2e/supporter/donor-access.cy.js":{"time":4560,"weight":8},"cypress/e2e/supporter/edit-member.cy.js":{"time":8660,"weight":15},"cypress/e2e/supporter/enter-organisation-name.cy.js":{"time":1581,"weight":2},"cypress/e2e/supporter/invite-member.cy.js":{"time":4497,"weight":8},"cypress/e2e/supporter/manage-organisation.cy.js":{"time":5119,"weight":9},"cypress/e2e/supporter/manage-team-members.cy.js":{"time":1987,"weight":3},"cypress/e2e/supporter/start.cy.js":{"time":1436,"weight":2},"cypress/e2e/supporter/suspended.cy.js":{"time":430,"weight":0},"cypress/e2e/supporter/view-lpa.cy.js":{"time":5841,"weight":10},"cypress/e2e/voucher/confirm-your-identity.cy.js":{"time":5545,"weight":9},"cypress/e2e/voucher/confirm-your-name.cy.js":{"time":4410,"weight":7},"cypress/e2e/voucher/enter-reference-number.cy.js":{"time":3826,"weight":6},"cypress/e2e/voucher/verify-donor-details.cy.js":{"time":742,"weight":1},"cypress/e2e/voucher/your-declaration.cy.js":{"time":831,"weight":1}} | ||
{"cypress/e2e/accessibility/data-loss-warning.cy.js":{"time":2788,"weight":5},"cypress/e2e/attorney/confirm-your-details.cy.js":{"time":5753,"weight":10},"cypress/e2e/attorney/language-preferences.cy.js":{"time":1248,"weight":2},"cypress/e2e/attorney/legal-rights-and-responsibilities.cy.js":{"time":426,"weight":0},"cypress/e2e/attorney/opt-out.cy.js":{"time":1309,"weight":2},"cypress/e2e/attorney/phone-number.cy.js":{"time":1925,"weight":3},"cypress/e2e/attorney/progress.cy.js":{"time":1458,"weight":2},"cypress/e2e/attorney/read-the-lpa.cy.js":{"time":545,"weight":0},"cypress/e2e/attorney/sign.cy.js":{"time":3794,"weight":6},"cypress/e2e/attorney/start.cy.js":{"time":175,"weight":0},"cypress/e2e/attorney/task-list.cy.js":{"time":499,"weight":0},"cypress/e2e/attorney/trust-corporation.cy.js":{"time":13500,"weight":24},"cypress/e2e/attorney/what-happens-when-you-sign-the-lpa.cy.js":{"time":1459,"weight":2},"cypress/e2e/certificate-provider/certificate-provided.cy.js":{"time":1200,"weight":2},"cypress/e2e/certificate-provider/choose-not-to-be-a-certificate-provider.cy.js":{"time":2382,"weight":4},"cypress/e2e/certificate-provider/confirm-your-details.cy.js":{"time":4867,"weight":8},"cypress/e2e/certificate-provider/confirm-your-identity.cy.js":{"time":5460,"weight":9},"cypress/e2e/certificate-provider/dashboard.cy.js":{"time":1224,"weight":2},"cypress/e2e/certificate-provider/enter-date-of-birth.cy.js":{"time":6545,"weight":11},"cypress/e2e/certificate-provider/enter-reference-number.cy.js":{"time":3879,"weight":7},"cypress/e2e/certificate-provider/language-preferences.cy.js":{"time":1161,"weight":2},"cypress/e2e/certificate-provider/provide-certificate.cy.js":{"time":2136,"weight":3},"cypress/e2e/certificate-provider/read-the-lpa.cy.js":{"time":1511,"weight":2},"cypress/e2e/certificate-provider/start.cy.js":{"time":295,"weight":0},"cypress/e2e/certificate-provider/task-list.cy.js":{"time":452,"weight":0},"cypress/e2e/certificate-provider/what-is-your-home-address.cy.js":{"time":10634,"weight":19},"cypress/e2e/certificate-provider/who-is-eligible.cy.js":{"time":563,"weight":1},"cypress/e2e/dev-features.cy.js":{"time":362,"weight":0},"cypress/e2e/donor/add-correspondent.cy.js":{"time":8121,"weight":14},"cypress/e2e/donor/can-you-sign-your-lpa.cy.js":{"time":916,"weight":1},"cypress/e2e/donor/certificate-provider.cy.js":{"time":17522,"weight":31},"cypress/e2e/donor/check-you-can-sign.cy.js":{"time":1020,"weight":1},"cypress/e2e/donor/check-your-details.cy.js":{"time":1386,"weight":2},"cypress/e2e/donor/check-your-lpa.cy.js":{"time":9361,"weight":16},"cypress/e2e/donor/choose-attorneys-address.cy.js":{"time":10275,"weight":18},"cypress/e2e/donor/choose-attorneys-summary.cy.js":{"time":7591,"weight":13},"cypress/e2e/donor/choose-attorneys-task.cy.js":{"time":20301,"weight":36},"cypress/e2e/donor/choose-attorneys.cy.js":{"time":11407,"weight":20},"cypress/e2e/donor/choose-people-to-notify-address.cy.js":{"time":4029,"weight":7},"cypress/e2e/donor/choose-replacement-attorneys-address.cy.js":{"time":7568,"weight":13},"cypress/e2e/donor/choose-replacement-attorneys-summary.cy.js":{"time":7228,"weight":13},"cypress/e2e/donor/choose-replacement-attorneys-task.cy.js":{"time":120591,"weight":218},"cypress/e2e/donor/choose-replacement-attorneys.cy.js":{"time":12531,"weight":22},"cypress/e2e/donor/choose-someone-to-vouch-for-you.cy.js":{"time":717,"weight":1},"cypress/e2e/donor/confirm-person-allowed-to-vouch.cy.js":{"time":4421,"weight":7},"cypress/e2e/donor/confirm-your-certificate-provider-is-not-related.cy.js":{"time":2027,"weight":3},"cypress/e2e/donor/confirm-your-identity.cy.js":{"time":11599,"weight":20},"cypress/e2e/donor/cost-of-repeat-application.cy.js":{"time":969,"weight":1},"cypress/e2e/donor/dashboard.cy.js":{"time":3479,"weight":6},"cypress/e2e/donor/delete-lpa.cy.js":{"time":1152,"weight":2},"cypress/e2e/donor/enter-access-code.cy.js":{"time":1116,"weight":2},"cypress/e2e/donor/enter-replacement-trust-corporation-address.cy.js":{"time":10638,"weight":19},"cypress/e2e/donor/enter-replacement-trust-corporation.cy.js":{"time":2391,"weight":4},"cypress/e2e/donor/enter-trust-corporation-address.cy.js":{"time":10880,"weight":19},"cypress/e2e/donor/enter-trust-corporation.cy.js":{"time":2383,"weight":4},"cypress/e2e/donor/enter-voucher.cy.js":{"time":2085,"weight":3},"cypress/e2e/donor/how-should-attorneys-make-decisions.cy.js":{"time":3185,"weight":5},"cypress/e2e/donor/how-should-replacement-attorneys-make-decisions.cy.js":{"time":2358,"weight":4},"cypress/e2e/donor/how-should-replacement-attorneys-step-in.cy.js":{"time":2089,"weight":3},"cypress/e2e/donor/language-preferences.cy.js":{"time":1270,"weight":2},"cypress/e2e/donor/life-sustaining-treatment.cy.js":{"time":1399,"weight":2},"cypress/e2e/donor/lpa-type.cy.js":{"time":6386,"weight":11},"cypress/e2e/donor/make-a-new-lpa.cy.js":{"time":4584,"weight":8},"cypress/e2e/donor/payment.cy.js":{"time":28775,"weight":52},"cypress/e2e/donor/people-to-notify.cy.js":{"time":10771,"weight":19},"cypress/e2e/donor/previous-application-number.cy.js":{"time":1312,"weight":2},"cypress/e2e/donor/progress.cy.js":{"time":3162,"weight":5},"cypress/e2e/donor/provide-your-details.cy.js":{"time":4999,"weight":9},"cypress/e2e/donor/remove-replacement-trust-corporation.cy.js":{"time":920,"weight":1},"cypress/e2e/donor/remove-trust-corporation.cy.js":{"time":846,"weight":1},"cypress/e2e/donor/restrictions.cy.js":{"time":837,"weight":1},"cypress/e2e/donor/sign-the-lpa.cy.js":{"time":8701,"weight":15},"cypress/e2e/donor/signing-on-behalf.cy.js":{"time":3069,"weight":5},"cypress/e2e/donor/start.cy.js":{"time":740,"weight":1},"cypress/e2e/donor/task-list.cy.js":{"time":429,"weight":0},"cypress/e2e/donor/view-lpa.cy.js":{"time":1465,"weight":2},"cypress/e2e/donor/want-replacement-attorneys.cy.js":{"time":2326,"weight":4},"cypress/e2e/donor/what-you-can-do-now.cy.js":{"time":17541,"weight":31},"cypress/e2e/donor/when-can-the-lpa-be-used.cy.js":{"time":895,"weight":1},"cypress/e2e/donor/withdraw-lpa.cy.js":{"time":1289,"weight":2},"cypress/e2e/donor/you-cannot-sign-your-lpa-yet.cy.js":{"time":18,"weight":0},"cypress/e2e/donor/your-address.cy.js":{"time":8000,"weight":14},"cypress/e2e/donor/your-authorised-signatory.cy.js":{"time":2090,"weight":3},"cypress/e2e/donor/your-date-of-birth.cy.js":{"time":4916,"weight":8},"cypress/e2e/donor/your-independent-witness-address.cy.js":{"time":9977,"weight":18},"cypress/e2e/donor/your-independent-witness-mobile.cy.js":{"time":2271,"weight":4},"cypress/e2e/donor/your-independent-witness.cy.js":{"time":2502,"weight":4},"cypress/e2e/donor/your-name.cy.js":{"time":2708,"weight":4},"cypress/e2e/error-pages.cy.js":{"time":1483,"weight":2},"cypress/e2e/navigation.cy.js":{"time":547,"weight":0},"cypress/e2e/supporter/add-correspondent.cy.js":{"time":11371,"weight":20},"cypress/e2e/supporter/dashboard.cy.js":{"time":8644,"weight":15},"cypress/e2e/supporter/donor-access.cy.js":{"time":4748,"weight":8},"cypress/e2e/supporter/edit-member.cy.js":{"time":8195,"weight":14},"cypress/e2e/supporter/enter-organisation-name.cy.js":{"time":1632,"weight":2},"cypress/e2e/supporter/invite-member.cy.js":{"time":4600,"weight":8},"cypress/e2e/supporter/manage-organisation.cy.js":{"time":4405,"weight":7},"cypress/e2e/supporter/manage-team-members.cy.js":{"time":2786,"weight":5},"cypress/e2e/supporter/start.cy.js":{"time":1307,"weight":2},"cypress/e2e/supporter/suspended.cy.js":{"time":391,"weight":0},"cypress/e2e/supporter/view-lpa.cy.js":{"time":7191,"weight":13},"cypress/e2e/voucher/confirm-your-identity.cy.js":{"time":6196,"weight":11},"cypress/e2e/voucher/confirm-your-name.cy.js":{"time":4304,"weight":7},"cypress/e2e/voucher/enter-reference-number.cy.js":{"time":3683,"weight":6},"cypress/e2e/voucher/verify-donor-details.cy.js":{"time":803,"weight":1},"cypress/e2e/voucher/your-declaration.cy.js":{"time":833,"weight":1}} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there were changes after the original ticket I think this assertion was incorrect.