MLPAB-1743: Create a new LPA as a supporter #1017
Conversation
acsauk
had a problem deploying
to
dev_1017mlpab17
GitHub Actions
Failure
acsauk
had a problem deploying
to
dev_1017mlpab17
GitHub Actions
Failure
| @@ -93,6 +111,37 @@ func (s *organisationStore) CreateMemberInvite(ctx context.Context, organisation | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *organisationStore) CreateLPA(ctx context.Context, organisationID string) (*actor.DonorProvidedDetails, error) { | |||
There was a problem hiding this comment.
I'm leaving this here for now. We could probably modify donorStore.Create() but I didn't want to have to think through the LpaLink implications until we need it for the dashboard.
| @@ -35,22 +35,30 @@ func LoginCallback(oneLoginClient LoginCallbackOneLoginClient, sessionStore sesh | |||
|
|
|||
| session := &sesh.LoginSession{ | |||
| IDToken: idToken, | |||
| Sub: userInfo.Sub, | |||
| Sub: "supporter-" + userInfo.Sub, | |||
There was a problem hiding this comment.
Good call on this @hawx - protection against GOL accounts being used in supporter/non-supporter journeys.
acsauk
had a problem deploying
to
dev_1017mlpab17
GitHub Actions
Failure
acsauk
had a problem deploying
to
dev_1017mlpab17
GitHub Actions
Failure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
- Coverage 92.14% 92.10% -0.05%
==========================================
Files 181 182 +1
Lines 8025 8081 +56
==========================================
+ Hits 7395 7443 +48
- Misses 510 514 +4
- Partials 120 124 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
acsauk
temporarily deployed
to
dev_1017mlpab17
GitHub Actions
Inactive
acsauk
temporarily deployed
to
dev_1017mlpab17
GitHub Actions
Inactive
| @@ -98,6 +98,7 @@ body:not(.js-enabled) .govuk-back-link { | |||
| @include govuk-media-query($from: tablet) { | |||
| @include govuk-responsive-padding(4, "bottom"); | |||
| } | |||
| color: govuk-colour("black"); | |||
There was a problem hiding this comment.
Following design review
acsauk
temporarily deployed
to
dev_1017mlpab17
GitHub Actions
Inactive
| if err == nil { | ||
| session.OrganisationID = organisation.ID |
There was a problem hiding this comment.
We could extend session with OrganisationName too, then we can let that flow through to AppData so the header contains it. Having it not be "live" is an ok tradeoff for now?
There was a problem hiding this comment.
Yeah thats probably a good idea, I'll add in.
acsauk
temporarily deployed
to
dev_1017mlpab17
GitHub Actions
Inactive
Purpose
The bulk of change here is getting the required data in session to make the jump from supporter to donor handlers. There will need to be a follow-up ticket to fix any issues encountered in the donor flow while acting as a supporter.
Fixes MLPAB-1743