Security and maintainability fixes #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Alpine 3.19 for fixtures container: this contains the libexpat patch and others. Move the properties file to the name used for cloud analysis (I'd previously used the one for CI analysis). Some minor maintainability fixes that were easy to fix. #patch
mattmachell
reviewed
Oct 15, 2024
fixtures/Dockerfile
Outdated
| @@ -6,14 +6,12 @@ COPY fixtures/package.json package.json | |||
| COPY fixtures/package-lock.json package-lock.json | |||
| RUN npm ci --ignore-scripts | |||
|
|
|||
| FROM python:3-alpine3.17 | |||
| FROM python:3-alpine3.19 | |||
There was a problem hiding this comment.
You might want a specific python version here to avoid unexpected upgrades and breakage.
There was a problem hiding this comment.
Yeah, fair, I've pinned to 3.13
#patch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a few issues highlighted by Trivy and SonarCloud
#patch
Approach
Use Alpine 3.19 for fixtures container: this contains the libexpat patch and others.
Move the properties file to the name used for cloud analysis (I'd previously used the one for CI analysis).
Some minor maintainability fixes that were easy to fix.
Learning
The various ways you can configure SonarCloud caused me some confusion, but it seems we want
.sonarcloud.propertiesas our configuration file name for it to be picked up properly.