Use Secrets Manager for JWT secret #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtyler
force-pushed
the
VEGA-2424-use-secretsmanager
branch
from
e304cb2
to
a9234ac
Compare
gregtyler
force-pushed
the
VEGA-2424-use-secretsmanager
branch
from
a9234ac
to
9252e13
Compare
gregtyler
force-pushed
the
VEGA-2424-use-secretsmanager
branch
from
9252e13
to
6592a23
Compare
gregtyler
force-pushed
the
VEGA-2424-use-secretsmanager
branch
from
6592a23
to
721e046
Compare
gregtyler
force-pushed
the
VEGA-2424-use-secretsmanager
branch
4 times, most recently
from
a206061
to
2e46b21
Compare
gregtyler
force-pushed
the
VEGA-2424-use-secretsmanager
branch
from
2e46b21
to
1754722
Compare
Rather than passing it in as an easily-leakable environment variable, use Secrets Manager to store the secret used for JWT key signing For VEGA-2424 #minor
gregtyler
force-pushed
the
VEGA-2424-use-secretsmanager
branch
from
1754722
to
9eecbcc
Compare
townxelliot
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than passing it in as an easily-leakable environment variable, use Secrets Manager to store the secret used for JWT key signing
For VEGA-2424 #minor