Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button menu updates #825

Merged
merged 34 commits into from
Oct 28, 2024
Merged

Button menu updates #825

merged 34 commits into from
Oct 28, 2024

Conversation

chrispymm
Copy link
Contributor

Update button menu

@chrispymm
feat(button menu): update the button menu to new specification
d80fb39 
This update removes the flexible buttion grouping functionality and makes the component solely
responsible for making a toggle button menu

BREAKING CHANGE: The component no longer handles being a button group, and it no longer responsively
switches between a button group and a button menu
@chrispymm
feat(button menu): wip - continued work on updated button menu
c8fa1f6
@chrispymm chrispymm requested a review from a team as a code owner October 8, 2024 09:29
@chrispymm chrispymm added the staging:request Add this label to request a staging environment for a pull request label Oct 8, 2024
helennickols
helennickols previously approved these changes Oct 9, 2024
View reviewed changes
@chrispymm chrispymm dismissed helennickols’s stale review October 9, 2024 15:57

Not ready for review yet

@chrispymm chrispymm added staging:request Add this label to request a staging environment for a pull request and removed staging:request Add this label to request a staging environment for a pull request labels Oct 9, 2024
@chrispymm chrispymm added staging:request Add this label to request a staging environment for a pull request and removed staging:request Add this label to request a staging environment for a pull request labels Oct 10, 2024
@chrispymm chrispymm force-pushed the button-menu-updates branch from c1a01bd to 6f8b3da Compare October 10, 2024 06:58
@chrispymm chrispymm added staging:request Add this label to request a staging environment for a pull request and removed staging:request Add this label to request a staging environment for a pull request labels Oct 10, 2024
@github-actions GitHub Actions
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request labels Oct 10, 2024
@robertjmccarthy robertjmccarthy added staging:request Add this label to request a staging environment for a pull request and removed staging:active Automatic label added when the PR is on the staging environment labels Oct 10, 2024
@github-actions GitHub Actions
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request labels Oct 10, 2024
@chrispymm chrispymm force-pushed the button-menu-updates branch from 8f1164c to 15c527e Compare October 10, 2024 13:49
@chrispymm chrispymm added staging:request Add this label to request a staging environment for a pull request and removed staging:active Automatic label added when the PR is on the staging environment labels Oct 10, 2024
@chrispymm chrispymm added staging:request Add this label to request a staging environment for a pull request and removed staging:active Automatic label added when the PR is on the staging environment labels Oct 28, 2024
@github-actions GitHub Actions
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request labels Oct 28, 2024
@chrispymm chrispymm added staging:request Add this label to request a staging environment for a pull request and removed staging:active Automatic label added when the PR is on the staging environment labels Oct 28, 2024
@github-actions GitHub Actions
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request labels Oct 28, 2024
@chrispymm chrispymm added staging:request Add this label to request a staging environment for a pull request and removed staging:active Automatic label added when the PR is on the staging environment labels Oct 28, 2024
@github-actions GitHub Actions
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request labels Oct 28, 2024
@chrispymm chrispymm added staging:request Add this label to request a staging environment for a pull request and removed staging:active Automatic label added when the PR is on the staging environment labels Oct 28, 2024
@github-actions GitHub Actions
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request labels Oct 28, 2024
@chrispymm chrispymm merged commit d989f2d into main Oct 28, 2024
19 checks passed
@chrispymm chrispymm deleted the button-menu-updates branch October 28, 2024 13:21
gregtyler pushed a commit that referenced this pull request Oct 28, 2024
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
62ffe77 
# [3.0.0](v2.2.4...v3.0.0) (2024-10-28)

### Features

* **button menu:** Button menu updates ([#825](#825)) ([d989f2d](d989f2d))

### BREAKING CHANGES

* **button menu:** The component no longer handles being a button group, and it no longer responsively
switches between a button group and a button menu

* feat(button menu): wip - continued work on updated button menu

* feat(button menu): wip - work on styles and interaction details

* ci(husky): prevent husky failing on staging deploy

* docs(updating documentation content): updating button menu documentation content

* feat(button menu): final updates to button menu and adjust page header actions

* feat(button menu): create examples for button menu

* feat(button menu): remove menu and menuitem roles and switch to list

This is not a real "menu" in accessibility terms, so the role is incorrect, and using menuitem on the
items removes link/button semantics

* feat(button menu): update tests for new structure and test js and data api

* Changes to button menu guidance

- Added example images
- Updated 'help and feedback' partial
- Reviewed heading levels

* Updating example image

Updating example image

* feat(button menu): styling changes to improve accessibility

* feat(button menu): refactor initMenu method

* refactor(button menu): tidy up for code review

* feat(button menu): updates to identity bar and page header actions

* feat(button menu): changes from code review and add tests for single button instance

* feat(button menu): update examples to use secondary button style, fix chevron alignment

* Button menu updates

- Updated "what's new" on homepage
- Updated Get help and contribute section on button menu page
- Updated example images
- Reverted 'Suggest a change' box

* docs(identity bar component updates): updates to the identity bar component based on the button menu

* docs(updating documentation content): updating identity bar documentation

* docs(updating documentation content): updating button menu documentation

Adding link to GOV.UK Design System button group
Changing multiple mention of default
Changing Github content

* feat(button menu): set default example to use button tags

* docs(updating documentation content): updating button menu documentation

Including content about WCAG failure for using component as menu

* feat(button menu and date picker): update example images to png

* feat(page header actions): update to use moj-button-group instead of button-menu

* feat(button menu): update the nunjucks arguments documentation

* fix(button menu): add in anchor link to button attributes within nunjucks arguments

* fix(button menu): remove space to fix anchor link

* docs(button menu): fix references to input in items text and html docs

* docs(button menu): remove unnecessary govuk button include in default example

* docs(button menu): final few tweaks

* docs(button menu): minor content changes

* docs(identity bar): update relative links in page

* fix(button menu): fix button spacings on very small screens
@gregtyler
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregtyler gregtyler gregtyler left review comments

@helennickols helennickols helennickols approved these changes

Assignees
No one assigned
Labels
released staging:active Automatic label added when the PR is on the staging environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrispymm @gregtyler @helennickols @robertjmccarthy @murrlipp