Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include compiled css and js in the package #1028

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

chrispymm
Copy link
Contributor

@chrispymm chrispymm commented Dec 17, 2024

This PR adjusts the build:package task to also output a compiled minified js and css file. It also fixes the compiled output including jQuery, which didn't work due to jQuery ending up bundled by the umd.

It also adds in a version string onto the MOJFrontend object, that should get updated by semantic release

This PR adjusts the build:package task to also output a compiled minified js and css file. It also
fixes the compiled output including jQuery, which didn't  work due to jQuery ending up bundled by
the umd
@chrispymm chrispymm requested a review from a team as a code owner December 17, 2024 12:21
@chrispymm chrispymm merged commit c4f2d6f into main Dec 18, 2024
19 checks passed
@chrispymm chrispymm deleted the include-compiled-assets-in-package branch December 18, 2024 14:01
gregtyler pushed a commit that referenced this pull request Dec 18, 2024
## [3.2.2](v3.2.1...v3.2.2) (2024-12-18)

### Bug Fixes

* include compiled css and js in the package ([#1028](#1028)) ([c4f2d6f](c4f2d6f)), closes [#1024](#1024)
@gregtyler
Copy link
Contributor

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants