Design system sass import broken in Rails apps #927
Labels
bug
A task that fixes something that isn't working
Comments
chrispymm
added a commit
that referenced
this issue
Nov 15, 2024
This allows us to remove the node modules prefix from the govuk scss import in all.scss. Which would resolve loading issues for users. BREAKING CHANGE: This PR changes the loadpath for govuk frontend. You will now need to ensure your project SASS configuration includes node_modules within its loadpaths in order to compile, however this is often default behaviour in many build tools. fix #927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
all.sccsin our package contains an import with the path@import node_modules/govuk-frontend/dist/govuk/baseThis path seems to be causing some users issues when including it into their projects, and they cannot build the design system css.
This issues seems to primarily affect rails projects:
rails/cssbundling-rails#101
rails/cssbundling-rails@9075819
cssbundling rails includes node_modules in the load path automatically, so having it in the import path in the sass file causes it to fail.
The recommendation from govuk, is to use the full path for imports (https://frontend.design-system.service.gov.uk/import-css/#import-specific-parts-using-sass)
Fixing this for rails projects, could cause issues for others...
The text was updated successfully, but these errors were encountered: