feat(version): add version variable to bundle js #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispymm
changed the base branch from
main
to
include-compiled-assets-in-package
chrispymm
merged commit 69fc80c
into
include-compiled-assets-in-package
18 checks passed
chrispymm
added a commit
that referenced
this pull request
Dec 18, 2024
* fix: include compiled css and js in the package This PR adjusts the build:package task to also output a compiled minified js and css file. It also fixes the compiled output including jQuery, which didn't work due to jQuery ending up bundled by the umd * fix(version): add version variable to bundle js (#1024)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should include the semantic release version number within the exported bundle js.
It does this by including a version.js file which contains a placeholder version string assigned to
MOJFrontend.versionThere is then a plugin for semantic release which should be able to find and replace this string within the compiled js output 🤞