allow further roles to remove tf locks #9050

dms1981 · 2025-01-23T11:23:54Z

A reference to the issue / Description of it

#8345

How does this PR fix the problem?

Adds statements to S3 bucket policy that allow terraform native locks to be deleted.

How has this been tested?

Tested through CI pipeline. PR adds permissions, so there ought to be no impact to existing workflows

Deployment Plan / Instructions

Deploy through CI

Checklist (check `x` in `[ ]` of list items)

I have performed a self-review of my own code
All checks have passed
I have made corresponding changes to the documentation
Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

github-actions · 2025-01-23T11:25:31Z

Terraform Plan Summary

modernisation-platform-account
Plan: 0 to add, 1 to change, 0 to destroy.

github-actions · 2025-01-23T11:26:19Z

`Trivy Scan` Success

Show Output

```hcl

Trivy will check the following folders:
terraform/modernisation-platform-account

Running Trivy in terraform/modernisation-platform-account
2025-01-23T11:25:58Z INFO [vulndb] Need to update DB
2025-01-23T11:25:58Z INFO [vulndb] Downloading vulnerability DB...
2025-01-23T11:25:58Z INFO [vulndb] Downloading artifact... repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-23T11:26:00Z INFO [vulndb] Artifact successfully downloaded repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-23T11:26:00Z INFO [vuln] Vulnerability scanning is enabled
2025-01-23T11:26:00Z INFO [misconfig] Misconfiguration scanning is enabled
2025-01-23T11:26:00Z INFO [misconfig] Need to update the built-in checks
2025-01-23T11:26:00Z INFO [misconfig] Downloading the built-in checks...
164.50 KiB / 164.50 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2025-01-23T11:26:00Z INFO [secret] Secret scanning is enabled
2025-01-23T11:26:00Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-23T11:26:00Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-23T11:26:01Z INFO [terraform scanner] Scanning root module file_path="."
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-account: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-assumable-roles: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-group-with-policies: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-enforce-group-mfa" range="git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=e803e25ce20a6ebd5579e0896f657fa739f6f03e/modules/iam-group-with-policies/main.tf:5-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z INFO [terraform executor] Ignore finding rule="aws-s3-encryption-customer-key" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf:157-165"
2025-01-23T11:26:12Z INFO Number of language-specific files num=0
2025-01-23T11:26:12Z INFO Detected config files num=7
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/modernisation-platform-account

*****************************

Running Checkov in terraform/modernisation-platform-account
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2025-01-23 11:26:15,412 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-iam-superadmins?ref=bea5d084de2f810eee5326562ad6d9d104a2aa05:None (for external modules, the --download-external-modules flag is required)
2025-01-23 11:26:15,413 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-group-with-policies:~> 5.0 (for external modules, the --download-external-modules flag is required)
2025-01-23 11:26:15,413 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-role?ref=62b8a16c73d8e4422cd81923e46948e8f4b5cf48:None (for external modules, the --download-external-modules flag is required)
2025-01-23 11:26:15,413 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=82f546bd5f002674138a2ccdade7d7618c6758b3:None (for external modules, the --download-external-modules flag is required)
2025-01-23 11:26:15,413 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/terraform-aws-observability-platform-tenant?ref=fbbe5c8282786bcc0a00c969fe598e14f12eea9b:None (for external modules, the --download-external-modules flag is required)
2025-01-23 11:26:15,413 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a:None (for external modules, the --download-external-modules flag is required)
2025-01-23 11:26:15,413 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 244, Failed checks: 0, Skipped checks: 30


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/modernisation-platform-account

*****************************

Running tflint in terraform/modernisation-platform-account
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Success

Show Output

*****************************

Trivy will check the following folders:
terraform/modernisation-platform-account

*****************************

Running Trivy in terraform/modernisation-platform-account
2025-01-23T11:25:58Z	INFO	[vulndb] Need to update DB
2025-01-23T11:25:58Z	INFO	[vulndb] Downloading vulnerability DB...
2025-01-23T11:25:58Z	INFO	[vulndb] Downloading artifact...	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-23T11:26:00Z	INFO	[vulndb] Artifact successfully downloaded	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-23T11:26:00Z	INFO	[vuln] Vulnerability scanning is enabled
2025-01-23T11:26:00Z	INFO	[misconfig] Misconfiguration scanning is enabled
2025-01-23T11:26:00Z	INFO	[misconfig] Need to update the built-in checks
2025-01-23T11:26:00Z	INFO	[misconfig] Downloading the built-in checks...
164.50 KiB / 164.50 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2025-01-23T11:26:00Z	INFO	[secret] Secret scanning is enabled
2025-01-23T11:26:00Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-23T11:26:00Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-23T11:26:01Z	INFO	[terraform scanner] Scanning root module	file_path="."
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-account: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-assumable-roles: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-group-with-policies: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:10Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open modules/iam-user: no such file or directory"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-enforce-group-mfa" range="git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=e803e25ce20a6ebd5579e0896f657fa739f6f03e/modules/iam-group-with-policies/main.tf:5-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-topic-encryption-use-cmk" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/modules/config/main.tf:40"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-iam-no-user-attached-policies" range="terraform-aws-modules/iam/aws/modules/iam-user/modules/iam-user/main.tf:1-10"
2025-01-23T11:26:12Z	INFO	[terraform executor] Ignore finding	rule="aws-s3-encryption-customer-key" range="github.com/ministryofjustice/modernisation-platform-terraform-baselines?ref=dd8a60be4cc6d726803f49301930795d266188d8/github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1/main.tf:157-165"
2025-01-23T11:26:12Z	INFO	Number of language-specific files	num=0
2025-01-23T11:26:12Z	INFO	Detected config files	num=7
trivy_exitcode=0

allow further roles to remove tf locks

2ef50cc

dms1981 requested a review from a team as a code owner January 23, 2025 11:23

ep-93 approved these changes Jan 23, 2025

View reviewed changes

dms1981 added this pull request to the merge queue Jan 23, 2025

Merged via the queue into main with commit 7968fcb Jan 23, 2025
6 checks passed

dms1981 deleted the feature/8345-further-s3-permissions branch January 23, 2025 11:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow further roles to remove tf locks #9050

allow further roles to remove tf locks #9050

dms1981 commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

allow further roles to remove tf locks #9050

allow further roles to remove tf locks #9050

Conversation

dms1981 commented Jan 23, 2025

A reference to the issue / Description of it

How does this PR fix the problem?

How has this been tested?

Deployment Plan / Instructions

Checklist (check x in [ ] of list items)

Additional comments (if any)

github-actions bot commented Jan 23, 2025

Terraform Plan Summary

github-actions bot commented Jan 23, 2025

Trivy Scan Success

CTFLint Scan Success

Trivy Scan Success

Checklist (check `x` in `[ ]` of list items)

`Trivy Scan` Success

`CTFLint Scan` Success

`Trivy Scan` Success