Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated permissions scope #5958

Merged
merged 1 commit into from
Jan 11, 2024
Merged

updated permissions scope #5958

merged 1 commit into from
Jan 11, 2024

Conversation

AafAnsari
Copy link
Contributor

@AafAnsari AafAnsari commented Jan 11, 2024

A reference to the issue / Description of it

(#4998)

How does this PR fix the problem?](#4998)

Fixes code scanning vulnerability - https://github.com/ministryofjustice/modernisation-platform/security/code-scanning/1057

How has this been tested?

Created a TEST issue with "onboarding" label. Once the fix is merge, I'll close the issue which will trigger the workflow.

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@AafAnsari AafAnsari marked this pull request as ready for review January 11, 2024 16:02
@AafAnsari AafAnsari requested a review from a team as a code owner January 11, 2024 16:02
Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

@AafAnsari AafAnsari merged commit 31a6647 into main Jan 11, 2024
5 checks passed
@AafAnsari AafAnsari deleted the fix/token-permissions-vuln-2 branch January 11, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants