Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting out irrelevant checkov checks #215

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Commenting out irrelevant checkov checks #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c57dbfe
Commenting out irrelevant checkov checks
SteveLinden Sep 13, 2023
f8c46f7
Commit changes made by code formatters
github-actions[bot] Sep 13, 2023
b155a59
Correcting s3-bucket reference
SteveLinden Sep 13, 2023
62f5e3c
Merge branch 'fix/checkov-errors' of github.com:ministryofjustice/mod…
SteveLinden Sep 13, 2023
66a527b
terraform-docs: automated action
github-actions[bot] Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ If you're looking to raise an issue with this module, please create a new issue

| Name | Source | Version |
|------|--------|---------|
| <a name="module_s3-bucket"></a> [s3-bucket](#module\_s3-bucket) | github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket | v7.0.0 |
| <a name="module_s3-bucket"></a> [s3-bucket](#module\_s3-bucket) | github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket | 8688bc15a08fbf5a4f4eef9b7433c5a417df8df1 |

## Resources

Expand Down
12 changes: 11 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module "s3-bucket" {
count = var.existing_bucket_name == "" ? 1 : 0
source = "github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.0.0"
source = "github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1" # v7.0.0

providers = {
aws.bucket-replication = aws.bucket-replication
Expand Down Expand Up @@ -121,6 +121,16 @@ data "aws_elb_service_account" "default" {}
###### IAM #####

data "aws_iam_policy_document" "ssm-admin-policy-doc" {

# Not relevant to what we are doing. This sets a high level access policy
#checkov:skip=CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
#checkov:skip=CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
#checkov:skip=CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
#checkov:skip=CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
#checkov:skip=CKV_AWS_356: "Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions"
#checkov:skip=CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
#checkov:skip=CKV_TF_1: "Ensure Terraform module sources use a commit hash"

statement {
actions = ["s3:*",
"ec2:*",
Expand Down