Bump actions/checkout from 3.6.0 to 4.0.0 #206

dependabot · 2023-09-05T11:13:16Z

Bumps actions/checkout from 3.6.0 to 4.0.0.

Release notes

Sourced from actions/checkout's releases.

v4.0.0

What's Changed

Update default runtime to node20 by @takost in actions/checkout#1436

Support fetching without the --progress option by @simonbaird in actions/checkout#1067

Release 4.0.0 by @takost in actions/checkout#1447

New Contributors

@takost made their first contribution in actions/checkout#1436

@simonbaird made their first contribution in actions/checkout#1067

Full Changelog: actions/checkout@v3...v4.0.0

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.0.0

Support fetching without the --progress option

Update to node20

v3.6.0

Fix: Mark test scripts with Bash'isms to be run via Bash

Add option to fetch tags even if fetch-depth > 0

v3.5.3

Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in

Fix typos found by codespell

Add support for sparse checkouts

v3.5.2

Fix api endpoint for GHES

v3.5.1

Fix slow checkout on Windows

v3.5.0

Add new public key for known_hosts

v3.4.0

Upgrade codeql actions to v2

Upgrade dependencies

Upgrade @actions/io

v3.3.0

Implement branch list using callbacks from exec function

Add in explicit reference to private checkout options

[Fix comment typos (that got added in #770)](actions/checkout#1057)

v3.2.0

Add GitHub Action to perform release

Fix status badge

Replace datadog/squid with ubuntu/squid Docker image

Wrap pipeline commands for submoduleForeach in quotes

Update @actions/io to 1.1.2

Upgrading version to 3.2.0

v3.1.0

Use @actions/core saveState and getState

Add github-server-url input

v3.0.2

Add input set-safe-directory

v3.0.1

... (truncated)

Commits

3df4ab1 Release 4.0.0 (#1447)
8b5e8b7 Support fetching without the --progress option (#1067)
97a652b Update default runtime to node20 (#1436)
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@f43a0e5...3df4ab1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

github-actions · 2023-09-05T11:15:47Z

`TFSEC Scan` Failed

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

Results #1-14 HIGH IAM policy document uses wildcarded action 's3:*' (14 similar results)
────────────────────────────────────────────────────────────────────────────────
  main.tf:125-132
────────────────────────────────────────────────────────────────────────────────
  123    data "aws_iam_policy_document" "ssm-admin-policy-doc" {
  124      statement {
  125  ┌     actions = ["s3:*",
  126  │       "ec2:*",
  127  │       "ssm:*",
  128  │       "cloudwatch:*",
  129  │       "cloudformation:*",
  130  │       "iam:*",
  131  └       "lambda:*"
  ...  
────────────────────────────────────────────────────────────────────────────────
  Individual Causes
  - main.tf:123-135 (data.aws_iam_policy_document.ssm-admin-policy-doc) 14 instances
────────────────────────────────────────────────────────────────────────────────
          ID aws-iam-no-policy-wildcards
      Impact Overly permissive policies may grant access to sensitive resources
  Resolution Specify the exact permissions required, and to which resources they should apply instead of using wildcards.

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/iam/no-policy-wildcards/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document
────────────────────────────────────────────────────────────────────────────────


Results #15-16 HIGH IAM policy document uses sensitive action 's3:*' on wildcarded resource '*' (2 similar results)
────────────────────────────────────────────────────────────────────────────────
  main.tf:133
────────────────────────────────────────────────────────────────────────────────
  123    data "aws_iam_policy_document" "ssm-admin-policy-doc" {
  ...  
  133  [     resources = ["*"]
  ...  
  135    }
────────────────────────────────────────────────────────────────────────────────
  Individual Causes
  - main.tf:123-135 (data.aws_iam_policy_document.ssm-admin-policy-doc) 2 instances
────────────────────────────────────────────────────────────────────────────────
          ID aws-iam-no-policy-wildcards
      Impact Overly permissive policies may grant access to sensitive resources
  Resolution Specify the exact permissions required, and to which resources they should apply instead of using wildcards.

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/iam/no-policy-wildcards/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             225.402µs
  parsing              961.124099ms
  adaptation           368.803µs
  checks               10.99549ms
  total                972.713794ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     73
  files read           8

  results
  ──────────────────────────────────────────
  passed               8
  ignored              4
  critical             0
  high                 16
  medium               0
  low                  0

  8 passed, 4 ignored, 16 potential problem(s) detected.

tfsec_exitcode=1

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2023-09-05 11:15:44,711 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.0.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 28, Failed checks: 7, Skipped checks: 0

Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	FAILED for resource: module.ssm-auto-patching.aws_iam_policy_document.ssm-admin-policy-doc
	File: /main.tf:123-135
	Calling File: /test/unit-test/main.tf:1-16
	Guide: https://docs.paloaltonetworks.com/content/techdocs/en_US/prisma/prisma-cloud/prisma-cloud-code-security-policy-reference/aws-policies/aws-iam-policies/ensure-iam-policies-does-not-allow-privilege-escalation.html

		123 | data "aws_iam_policy_document" "ssm-admin-policy-doc" {
		124 |   statement {
		125 |     actions = ["s3:*",
		126 |       "ec2:*",
		127 |       "ssm:*",
		128 |       "cloudwatch:*",
		129 |       "cloudformation:*",
		130 |       "iam:*",
		131 |       "lambda:*"
		132 |     ]
		133 |     resources = ["*"]
		134 |   }
		135 | }

Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	FAILED for resource: module.ssm-auto-patching.aws_iam_policy_document.ssm-admin-policy-doc
	File: /main.tf:123-135
	Calling File: /test/unit-test/main.tf:1-16
	Guide: https://docs.paloaltonetworks.com/content/techdocs/en_US/prisma/prisma-cloud/prisma-cloud-code-security-policy-reference/aws-policies/aws-iam-policies/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint.html

		123 | data "aws_iam_policy_document" "ssm-admin-policy-doc" {
		124 |   statement {
		125 |     actions = ["s3:*",
		126 |       "ec2:*",
		127 |       "ssm:*",
		128 |       "cloudwatch:*",
		129 |       "cloudformation:*",
		130 |       "iam:*",
		131 |       "lambda:*"
		132 |     ]
		133 |     resources = ["*"]
		134 |   }
		135 | }

Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	FAILED for resource: module.ssm-auto-patching.aws_iam_policy_document.ssm-admin-policy-doc
	File: /main.tf:123-135
	Calling File: /test/unit-test/main.tf:1-16
	Guide: https://docs.paloaltonetworks.com/content/techdocs/en_US/prisma/prisma-cloud/prisma-cloud-code-security-policy-reference/aws-policies/aws-iam-policies/ensure-iam-policies-do-not-allow-credentials-exposure.html

		123 | data "aws_iam_policy_document" "ssm-admin-policy-doc" {
		124 |   statement {
		125 |     actions = ["s3:*",
		126 |       "ec2:*",
		127 |       "ssm:*",
		128 |       "cloudwatch:*",
		129 |       "cloudformation:*",
		130 |       "iam:*",
		131 |       "lambda:*"
		132 |     ]
		133 |     resources = ["*"]
		134 |   }
		135 | }

Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	FAILED for resource: module.ssm-auto-patching.aws_iam_policy_document.ssm-admin-policy-doc
	File: /main.tf:123-135
	Calling File: /test/unit-test/main.tf:1-16
	Guide: https://docs.paloaltonetworks.com/content/techdocs/en_US/prisma/prisma-cloud/prisma-cloud-code-security-policy-reference/aws-policies/aws-iam-policies/ensure-iam-policies-do-not-allow-data-exfiltration.html

		123 | data "aws_iam_policy_document" "ssm-admin-policy-doc" {
		124 |   statement {
		125 |     actions = ["s3:*",
		126 |       "ec2:*",
		127 |       "ssm:*",
		128 |       "cloudwatch:*",
		129 |       "cloudformation:*",
		130 |       "iam:*",
		131 |       "lambda:*"
		132 |     ]
		133 |     resources = ["*"]
		134 |   }
		135 | }

Check: CKV_AWS_356: "Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions"
	FAILED for resource: module.ssm-auto-patching.aws_iam_policy_document.ssm-admin-policy-doc
	File: /main.tf:123-135
	Calling File: /test/unit-test/main.tf:1-16

		123 | data "aws_iam_policy_document" "ssm-admin-policy-doc" {
		124 |   statement {
		125 |     actions = ["s3:*",
		126 |       "ec2:*",
		127 |       "ssm:*",
		128 |       "cloudwatch:*",
		129 |       "cloudformation:*",
		130 |       "iam:*",
		131 |       "lambda:*"
		132 |     ]
		133 |     resources = ["*"]
		134 |   }
		135 | }

Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	FAILED for resource: module.ssm-auto-patching.aws_iam_policy_document.ssm-admin-policy-doc
	File: /main.tf:123-135
	Calling File: /test/unit-test/main.tf:1-16
	Guide: https://docs.paloaltonetworks.com/content/techdocs/en_US/prisma/prisma-cloud/prisma-cloud-code-security-policy-reference/aws-policies/aws-iam-policies/ensure-iam-policies-do-not-allow-write-access-without-constraint.html

		123 | data "aws_iam_policy_document" "ssm-admin-policy-doc" {
		124 |   statement {
		125 |     actions = ["s3:*",
		126 |       "ec2:*",
		127 |       "ssm:*",
		128 |       "cloudwatch:*",
		129 |       "cloudformation:*",
		130 |       "iam:*",
		131 |       "lambda:*"
		132 |     ]
		133 |     resources = ["*"]
		134 |   }
		135 | }

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.ssm-auto-patching.s3-bucket
	File: /main.tf:3-57
	Calling File: /test/unit-test/main.tf:1-16

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 175, Failed checks: 1, Skipped checks: 0

Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: on(Generate Terraform README docs)
	File: /.github/workflows/documentation.yml:0-1

checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

dependabot bot requested a review from a team as a code owner September 5, 2023 11:13

dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 5, 2023

SteveLinden approved these changes Sep 5, 2023

View reviewed changes

dms1981 merged commit d43e2cb into main Sep 20, 2023

dms1981 deleted the dependabot/github_actions/actions/checkout-4.0.0 branch September 20, 2023 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump actions/checkout from 3.6.0 to 4.0.0 #206

Bump actions/checkout from 3.6.0 to 4.0.0 #206

dependabot bot commented on behalf of github Sep 5, 2023

github-actions bot commented Sep 5, 2023

Bump actions/checkout from 3.6.0 to 4.0.0 #206

Bump actions/checkout from 3.6.0 to 4.0.0 #206

Conversation

dependabot bot commented on behalf of github Sep 5, 2023

v4.0.0

What's Changed

New Contributors

Changelog

v4.0.0

v3.6.0

v3.5.3

v3.5.2

v3.5.1

v3.5.0

v3.4.0

v3.3.0

v3.2.0

v3.1.0

v3.0.2

v3.0.1

github-actions bot commented Sep 5, 2023

TFSEC Scan Failed

Checkov Scan Failed

CTFLint Scan Success

`TFSEC Scan` Failed

`Checkov Scan` Failed

`CTFLint Scan` Success