-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit-Tests - Add Exit Status #394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khatraf
approved these changes
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-s3-bucket
that referenced
this pull request
Jul 2, 2024
This was referenced Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-module-template
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-ecs-cluster
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-loadbalancer
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-ssm-patching
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-ec2-instance
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-ec2-autoscaling-group
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-lambda-function
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-baselines
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-cross-account-access
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-iam-superadmins
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-terraform-member-vpc
that referenced
this pull request
Jul 2, 2024
ASTRobinson
added a commit
to ministryofjustice/modernisation-platform-github-oidc-provider
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the go-terratest workflow to correctly handle the exit status of the go-test command. Due to the usage of the pipe (|) with redact-output.sh, the exit status of the last command in the pipe is returned, which in this case is the script redact-output.sh. If redact-output.sh does not correctly propagate the exit status of go-test, the workflow is reporting success even when tests fail.