Feature/allow security group to be passed in

[drobinson-moj]

Allow an existing security group(s) to be attached to the load balancer rather than creating one within the module. Helps keep the number of security groups down, and makes it easier to allow load balancer access in other security groups.

Tested backward compatibility, the terraform apply will automatically move the state, e.g.
module.loadbalancer["nomis-public"].aws_security_group.lb has moved to module.loadbalancer["nomis-public"].aws_security_group.lb[0]

[github-actions]

TFSEC Scan Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             214.201µs
  parsing              690.600857ms
  adaptation           316.202µs
  checks               24.321906ms
  total                715.453166ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     66
  files read           8

  results
  ──────────────────────────────────────────
  passed               12
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2023-01-26 14:46:28,654 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v6.2.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 26, Failed checks: 0, Skipped checks: 2

github_actions scan results:

Passed checks: 110, Failed checks: 2, Skipped checks: 0

Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: permissions
	File: /.github/workflows/documentation.yml:0-1
Check: CKV2_GHA_1: "Ensure top-level permissions are not set to write-all"
	FAILED for resource: permissions
	File: /.github/workflows/go-terratest.yml:0-1

checkov_exitcode=1

CTFLint Scan Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

[dms1981]

LGTM; passes unit tests, allows optional association with security group

[dms1981]

Re-reviewed. LGTM.