Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage location value not correct #334

Conversation

robertsweetman
Copy link
Contributor

@robertsweetman robertsweetman commented Jan 9, 2024

  • slight tweak to this to get the partitioning to behave correctly

follows docs https://docs.aws.amazon.com/athena/latest/ug/application-load-balancer-logs.html for partitioned logs

@robertsweetman robertsweetman marked this pull request as ready for review January 9, 2024 12:06
@robertsweetman robertsweetman requested a review from a team as a code owner January 9, 2024 12:06
Copy link
Contributor

github-actions bot commented Jan 9, 2024

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             220.551µs
  parsing              702.845298ms
  adaptation           262.26µs
  checks               9.378213ms
  total                712.706322ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-09 12:08:22,604 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 61, Failed checks: 0, Skipped checks: 2

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

Copy link
Contributor

@mikereiddigital mikereiddigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@robertsweetman robertsweetman merged commit 6f59e1c into main Jan 9, 2024
6 of 7 checks passed
@robertsweetman robertsweetman deleted the planetfm/DSOS-2408/fix-athena-table-alb-storage-location branch January 9, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants