Planetfm/dsos 2408/change access logs implementation #330

robertsweetman · 2024-01-02T14:21:39Z

CHANGES

adds network loadbalancer support for access_logs
fixes issue where each environment could not have more than one loadbalancer
removes the need for the glue_crawler
- removes cron requirement for glue crawler
- removing this fixes an issue where IAMRole/Policy names each needed to be unique
uses aws_glue_catalog_table for both application and network loadbalancer log availability and parsing in Athena
- tables are created automatically in athena and will parse application and network loadbalancer logs for you
fixed broken application lb test, has been broken for some time

README additions

permissions needed where an external bucket for logs is specified
note about needing to deploy the external bucket with the correct permissions BEFORE adding this variable
note regards needing to use depends_on when it comes to flipping access_logs from false to true after initial lb deployment
note about what Network loadbalancer access logs do and don't contain
reference to Athena tables
removed reference to running sql table create script manually as this is no longer needed

HOW HAS THIS BEEN TESTED?

deployed multiple lb's per environment
deployed existing S3 buckets of each type as well as relied on the module to create them automatically
log parsing for Application LB's checked already and these appear in the athena tables
followed existing docs for Network LB's log parsing setup
- I can't 'really' test this without deploying a LOT more infra so will do this in the planetfm pre-production environment and make any fixes needed there
- this was the motivation behind adding network load-balancer support to begin with

github-actions · 2024-01-02T15:54:06Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             239.366µs
  parsing              792.956732ms
  adaptation           267.138µs
  checks               4.889589ms
  total                798.352825ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     96
  files read           9

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-02 15:54:02,192 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 60, Failed checks: 1, Skipped checks: 2

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.lb_access_logs_enabled.s3-bucket
	File: /main.tf:9-64
	Calling File: /test/unit-test/main.tf:60-79
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=1

`CTFLint Scan` Failed

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
1 issue(s) found:

Warning: local.load_balancer_s3_module_dependency is declared but not used (terraform_unused_declarations)

  on locals.tf line 2:
   2:     load_balancer_s3_module_dependency = var.existing_bucket_name != "" ? [] : [module.s3_bucket]

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.1/docs/rules/terraform_unused_declarations.md

tflint_exitcode=2

github-actions · 2024-01-02T16:00:19Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             243.72µs
  parsing              342.695429ms
  adaptation           272.355µs
  checks               9.438781ms
  total                352.650285ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-02 16:00:17,308 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 60, Failed checks: 1, Skipped checks: 2

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.lb_access_logs_enabled.s3-bucket
	File: /main.tf:9-64
	Calling File: /test/unit-test/main.tf:60-79
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

github-actions · 2024-01-03T11:40:47Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             291.788µs
  parsing              522.042613ms
  adaptation           284.413µs
  checks               8.971551ms
  total                531.590365ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-03 11:40:44,839 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 60, Failed checks: 1, Skipped checks: 2

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.lb_access_logs_enabled.s3-bucket
	File: /main.tf:9-64
	Calling File: /test/unit-test/main.tf:60-79
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

github-actions · 2024-01-03T12:48:01Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             221.794µs
  parsing              854.69587ms
  adaptation           261.538µs
  checks               3.864771ms
  total                859.043973ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-03 12:47:57,785 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 60, Failed checks: 1, Skipped checks: 2

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.lb_access_logs_enabled.s3-bucket
	File: /main.tf:9-64
	Calling File: /test/unit-test/main.tf:60-79
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

github-actions · 2024-01-03T13:14:23Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             250.167µs
  parsing              371.835635ms
  adaptation           313.439µs
  checks               2.983374ms
  total                375.382615ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-03 13:14:20,999 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 60, Failed checks: 1, Skipped checks: 2

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.lb_access_logs_enabled.s3-bucket
	File: /main.tf:9-64
	Calling File: /test/unit-test/main.tf:60-79
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

github-actions · 2024-01-03T13:29:03Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             339.894µs
  parsing              492.717836ms
  adaptation           292.236µs
  checks               10.447509ms
  total                503.797475ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-03 13:29:00,250 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 60, Failed checks: 1, Skipped checks: 2

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.lb_access_logs_enabled.s3-bucket
	File: /main.tf:9-64
	Calling File: /test/unit-test/main.tf:60-79
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

github-actions · 2024-01-03T14:12:55Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             314.408µs
  parsing              489.284129ms
  adaptation           287.13µs
  checks               10.538674ms
  total                500.424341ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-03 14:12:52,856 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 60, Failed checks: 1, Skipped checks: 2

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.lb_access_logs_enabled.s3-bucket
	File: /main.tf:9-64
	Calling File: /test/unit-test/main.tf:60-79
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

github-actions · 2024-01-03T14:27:45Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             209.969µs
  parsing              383.544938ms
  adaptation           499.741µs
  checks               4.248163ms
  total                388.502811ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Failed

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-03 14:27:42,855 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 60, Failed checks: 1, Skipped checks: 2

Check: CKV_TF_1: "Ensure Terraform module sources use a commit hash"
	FAILED for resource: module.lb_access_logs_enabled.s3-bucket
	File: /main.tf:9-64
	Calling File: /test/unit-test/main.tf:60-79
	Guide: https://docs.prismacloud.io/en/enterprise-edition/policy-reference/supply-chain-policies/terraform-policies/ensure-terraform-module-sources-use-git-url-with-commit-hash-revision

		Code lines for this resource are too many. Please use IDE of your choice to review the file.
github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=1

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

SteveLinden

On the section containing this we would have a reference similar to the first with a comment on the version name

source = "github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1" # v7.0.0
source = "github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0"

github-actions · 2024-01-03T15:32:45Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             209.562µs
  parsing              590.912977ms
  adaptation           344.646µs
  checks               12.466008ms
  total                603.933193ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Success

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-03 15:32:42,067 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 61, Failed checks: 0, Skipped checks: 2

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

robertsweetman · 2024-01-03T15:34:30Z

On the section containing this we would have a reference similar to the first with a comment on the version name

source = "github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1" # v7.0.0 source = "github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v7.1.0"

@SteveLinden sorry, yep, forgot about that. Put the v7.1.0 in for expediency at the time 'cause I wasn't 100% on what the GUID actually was. Have changed it to the correct one now

github-actions · 2024-01-03T15:41:16Z

`TFSEC Scan` Success

Show Output

*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             393.653µs
  parsing              362.127513ms
  adaptation           269.061µs
  checks               3.585676ms
  total                366.375903ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     95
  files read           8

  results
  ──────────────────────────────────────────
  passed               10
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

`Checkov Scan` Success

Show Output

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2024-01-03 15:41:14,200 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 61, Failed checks: 0, Skipped checks: 2

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

ewastempel

LGTM

robertsweetman and others added 30 commits January 2, 2024 14:04

change default value to null and see what breaks

2e67770

revert existing bucket default value change

7bbdced

change storage descriptor

581c5f7

use athena db variable name

97fb888

use existing db name

6510108

put elasticloadalancing endpoint back

098b46a

terraform-docs: automated action

d39368a

Commit changes made by code formatters

b731c5a

fix de-serialisation, change names and types for columns

e6d42bd

terraform-docs: automated action

2ee64bb

remove timestamp types and use serde regex instead

db4d031

set athena engine version and update regex

e5698d3

capture IP addresses and ports separately

1c7ccfa

fix terraform escape sequences

d7836f9

fix incorrect character

b5e584e

correct regex column number

a0d4eee

add nlb log format and change log path

ffaa6e5

terraform-docs: automated action

e8ed350

remove glue crawler

3c48a34

remove glue crawler, change permissions

6d1eda3

terraform-docs: automated action

ac3f887

formatting

3fbe164

add missing definition

883d7f2

terraform-docs: automated action

de504ba

policy names must be unique

baaa6cf

update s3 bucket ref, make table resources conditional

53b42fb

terraform-docs: automated action

3d4afd7

use correct version tag syntax

022aca7

terraform-docs: automated action

415766f

remove un-used variable

b98408b

robertsweetman force-pushed the planetfm/DSOS-2408/change-access-logs-implementation branch from 835dcde to 0d4f8e3 Compare January 2, 2024 15:58

robertsweetman and others added 2 commits January 3, 2024 11:38

add depends_on s3 bucket module

d3efe8f

Commit changes made by code formatters

775e510

robertsweetman added 2 commits January 3, 2024 12:45

update readme

242ff4e

remove sql create table as this manual step is no longer needed

2fe90ed

robertsweetman force-pushed the planetfm/DSOS-2408/change-access-logs-implementation branch from 12f9aec to 2fe90ed Compare January 3, 2024 13:26

robertsweetman and others added 2 commits January 3, 2024 14:10

fix alb test

1e89cab

Commit changes made by code formatters

014b886

robertsweetman marked this pull request as ready for review January 3, 2024 14:20

robertsweetman requested a review from a team as a code owner January 3, 2024 14:20

typo

b0f45e9

SteveLinden reviewed Jan 3, 2024

View reviewed changes

robertsweetman and others added 2 commits January 3, 2024 15:30

use version GUID for s3 bucket module not version tag

af233ca

terraform-docs: automated action

b464eb4

force checks to rerun

9e3b4de

ewastempel approved these changes Jan 3, 2024

View reviewed changes

robertsweetman merged commit 4b518d4 into main Jan 3, 2024
5 checks passed

robertsweetman deleted the planetfm/DSOS-2408/change-access-logs-implementation branch January 3, 2024 15:58

richgreen-moj mentioned this pull request Jan 3, 2024

Load balancer module unit tests failing ministryofjustice/modernisation-platform#5846

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Planetfm/dsos 2408/change access logs implementation #330

Planetfm/dsos 2408/change access logs implementation #330

robertsweetman commented Jan 2, 2024 •

edited

Loading

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 2, 2024

github-actions bot commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

SteveLinden left a comment

github-actions bot commented Jan 3, 2024

robertsweetman commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

ewastempel left a comment

Planetfm/dsos 2408/change access logs implementation #330

Planetfm/dsos 2408/change access logs implementation #330

Conversation

robertsweetman commented Jan 2, 2024 • edited Loading

github-actions bot commented Jan 2, 2024

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Failed

github-actions bot commented Jan 2, 2024

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

github-actions bot commented Jan 3, 2024

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

github-actions bot commented Jan 3, 2024

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

github-actions bot commented Jan 3, 2024

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

github-actions bot commented Jan 3, 2024

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

github-actions bot commented Jan 3, 2024

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

github-actions bot commented Jan 3, 2024

TFSEC Scan Success

Checkov Scan Failed

CTFLint Scan Success

SteveLinden left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 3, 2024

TFSEC Scan Success

Checkov Scan Success

CTFLint Scan Success

robertsweetman commented Jan 3, 2024

github-actions bot commented Jan 3, 2024

TFSEC Scan Success

Checkov Scan Success

CTFLint Scan Success

ewastempel left a comment

Choose a reason for hiding this comment

robertsweetman commented Jan 2, 2024 •

edited

Loading

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Failed

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Failed

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Success

`CTFLint Scan` Success

`TFSEC Scan` Success

`Checkov Scan` Success

`CTFLint Scan` Success