Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added variable internal_lb #14

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Added variable internal_lb #14

merged 2 commits into from
Nov 8, 2022

Conversation

james-borwick
Copy link
Contributor

Adding a variable which allows for the creation of internal application load balancers.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             261.801µs
  parsing              2.009915586s
  adaptation           526.005µs
  checks               20.766366ms
  total                2.031469758s

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     65
  files read           8

  results
  ──────────────────────────────────────────
  passed               12
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2022-11-04 15:32:12,375 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v6.2.0:None (for external modules, the --download-external-modules flag is required)
Process ForkProcess-11:
Traceback (most recent call last):
  File "/usr/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
  File "/usr/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.7/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 37, in func_wrapper
    result = original_func(item)
  File "/usr/local/lib/python3.7/dist-packages/checkov/common/runners/runner_registry.py", line 89, in _parallel_run
    collect_skip_comments=collect_skip_comments,
  File "/usr/local/lib/python3.7/dist-packages/checkov/github/runner.py", line 34, in run
    self.prepare_data()
  File "/usr/local/lib/python3.7/dist-packages/checkov/github/runner.py", line 43, in prepare_data
    self.github.persist_all_confs()
  File "/usr/local/lib/python3.7/dist-packages/checkov/github/dal.py", line 137, in persist_all_confs
    self.persist_branch_protection_rules()
  File "/usr/local/lib/python3.7/dist-packages/checkov/github/dal.py", line 69, in persist_branch_protection_rules
    BaseVCSDAL.persist(path=self.github_branch_protection_rules_file_path, conf=data)
  File "/usr/local/lib/python3.7/dist-packages/checkov/common/vcs/base_vcs_dal.py", line 113, in persist
    BaseVCSDAL.ensure_dir(path)
  File "/usr/local/lib/python3.7/dist-packages/checkov/common/vcs/base_vcs_dal.py", line 123, in ensure_dir
    os.makedirs(directory_path)
  File "/usr/lib/python3.7/os.py", line 221, in makedirs
    mkdir(name, mode)
FileNotFoundError: [Errno 2] No such file or directory: ''
terraform scan results:

Passed checks: 23, Failed checks: 0, Skipped checks: 2

github_actions scan results:

Passed checks: 104, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

@james-borwick james-borwick marked this pull request as ready for review November 4, 2022 15:34
@james-borwick james-borwick requested a review from a team as a code owner November 4, 2022 15:34
ewastempel
ewastempel reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ewastempel
ewastempel approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkelliott davidkelliott reopened this Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS097, AWS018
  timings
  ──────────────────────────────────────────
  disk i/o             221.101µs
  parsing              976.853351ms
  adaptation           285.704µs
  checks               15.564477ms
  total                992.924633ms

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     65
  files read           8

  results
  ──────────────────────────────────────────
  passed               12
  ignored              5
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_GIT_1
2022-11-04 16:16:28,651 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=v6.2.0:None (for external modules, the --download-external-modules flag is required)
Process ForkProcess-11:
Traceback (most recent call last):
  File "/usr/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
  File "/usr/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.7/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 37, in func_wrapper
    result = original_func(item)
  File "/usr/local/lib/python3.7/dist-packages/checkov/common/runners/runner_registry.py", line 89, in _parallel_run
    collect_skip_comments=collect_skip_comments,
  File "/usr/local/lib/python3.7/dist-packages/checkov/github/runner.py", line 34, in run
    self.prepare_data()
  File "/usr/local/lib/python3.7/dist-packages/checkov/github/runner.py", line 43, in prepare_data
    self.github.persist_all_confs()
  File "/usr/local/lib/python3.7/dist-packages/checkov/github/dal.py", line 137, in persist_all_confs
    self.persist_branch_protection_rules()
  File "/usr/local/lib/python3.7/dist-packages/checkov/github/dal.py", line 69, in persist_branch_protection_rules
    BaseVCSDAL.persist(path=self.github_branch_protection_rules_file_path, conf=data)
  File "/usr/local/lib/python3.7/dist-packages/checkov/common/vcs/base_vcs_dal.py", line 113, in persist
    BaseVCSDAL.ensure_dir(path)
  File "/usr/local/lib/python3.7/dist-packages/checkov/common/vcs/base_vcs_dal.py", line 123, in ensure_dir
    os.makedirs(directory_path)
  File "/usr/lib/python3.7/os.py", line 221, in makedirs
    mkdir(name, mode)
FileNotFoundError: [Errno 2] No such file or directory: ''
terraform scan results:

Passed checks: 23, Failed checks: 0, Skipped checks: 2

github_actions scan results:

Passed checks: 104, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

@james-borwick james-borwick merged commit 1129c80 into main Nov 8, 2022
@james-borwick james-borwick deleted the dsos-1553-add-internal-lb-variable branch November 8, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewastempel ewastempel ewastempel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-borwick @ewastempel @davidkelliott