You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR completely removes all references to cloudposse and essentially re-writes it using plain old terraform resources.
Reasons why I want to do this:
using 3rd party modules but just copying the code makes it incredibly messy to update against the upstream
the feature to ignore task definition changes doesn't work
overall simplicity
This is a breaking change, but currently all consumers of this are using pinned to a version/release.
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Error: scan failed: github/workspace/container/main.tf:15,76-77: Missing item separator; Expected a comma to mark the beginning of the next item.
tfsec_exitcode=1
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Error: scan failed: github/workspace/container/main.tf:15,76-77: Missing item separator; Expected a comma to mark the beginning of the next item.
tfsec_exitcode=1
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Running TFSEC in .
Excluding the following checks: aws-cloudwatch-log-group-customer-key, aws-iam-no-policy-wildcards, aws-vpc-no-public-egress-sgr, aws-iam-block-kms-policy-wildcard, aws-vpc-add-description-to-security-group
======================================================
tfsec is joining the Trivy family
tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.
Result #1 LOW Cluster does not have container insights enabled.
────────────────────────────────────────────────────────────────────────────────
cluster/main.tf:6
────────────────────────────────────────────────────────────────────────────────
1 resource "aws_ecs_cluster" "this" {
2 name = var.name
3 tags = var.tags
4 setting {
5 name = "containerInsights"
6 [ value = var.enable_container_insights
7 }
8 }
────────────────────────────────────────────────────────────────────────────────
ID aws-ecs-enable-container-insight
Impact Not all metrics and logs may be gathered for containers when Container Insights isn't enabled
Resolution Enable Container Insights
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it stands the 'module' is mostly an opinionated wrapper to 2 cloudposse modules https://github.com/cloudposse/terraform-aws-ecs-alb-service-task and https://github.com/cloudposse/terraform-aws-ecs-container-definition. One of the agreements (set by MP) for using them was that we had to copy the code into the repo rather than call them remotely.
This PR completely removes all references to cloudposse and essentially re-writes it using plain old terraform resources.
Reasons why I want to do this:
using 3rd party modules but just copying the code makes it incredibly messy to update against the upstream
the feature to ignore task definition changes doesn't work
overall simplicity
This is a breaking change, but currently all consumers of this are using pinned to a version/release.