Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/checkov errors #162

Closed
wants to merge 6 commits into from
Closed

Fix/checkov errors #162

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
51b4d34
Added some checkov skips to cure errors
SteveLinden Dec 5, 2023
3031ff0
Moved github-token into the env: section to cure issue, maybe
SteveLinden Dec 5, 2023
ecfa2a7
Commit changes made by code formatters
github-actions[bot] Dec 5, 2023
6dbf979
Tidied up the checkov statements to add a space before them
SteveLinden Dec 5, 2023
74019a2
Tidied up the checkov statements to add a space before them
SteveLinden Dec 5, 2023
7419cf4
Commit changes made by code formatters
github-actions[bot] Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/unit-test/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ module "dns_mod" {
}

resource "aws_alb" "testalb" {
# A number of tests to ignore to stop errors in the overnight check
# checkov:skip=CKV_AWS_150 "Ensure that Load Balancer has deletion protection enabled - Not applicable in the test"
# checkov:skip=CKV_AWS_91: "Ensure the ELBv2 (Application/Network) has access logging enabled - not appropriate in the test"
# checkov:skip=CKV2_AWS_28: "Ensure public facing ALB are protected by WAF - not required in the test"
name = "alb-test"
internal = false
load_balancer_type = "application"
Expand Down