Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointed to latest s3-bucket release and stopped a KMS checkov - CKV2_A… #275

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

SteveLinden
Copy link
Contributor

…WS_64 - check.

Wanted to check the KMS key.

Another checkov (CKV_TF_1) is showing as failing but may be cured by pointing to the latest version of the modernisation-platform-terraform-s3-bucket code. If not additional work is required.

@SteveLinden SteveLinden requested a review from a team as a code owner October 17, 2023 10:57
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
.

*****************************

Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             291.806µs
  parsing              1.105294699s
  adaptation           1.059922ms
  checks               9.840111ms
  total                1.116486538s

  counts
  ──────────────────────────────────────────
  modules downloaded   1
  modules processed    2
  blocks processed     102
  files read           8

  results
  ──────────────────────────────────────────
  passed               16
  ignored              44
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2023-10-17 12:23:17,128 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 70, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

@SteveLinden SteveLinden changed the title Pinted to latest s3-bucket release and stopped a KMS checkov - CKV2_A… Pointed to latest s3-bucket release and stopped a KMS checkov - CKV2_A… Oct 17, 2023
@SteveLinden SteveLinden merged commit b922c8c into main Oct 17, 2023
@SteveLinden SteveLinden deleted the fix/checkov-errors-#4872 branch October 17, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants