Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use svc_join_domain user #9040

Merged
merged 1 commit into from
Dec 10, 2024
Merged

use svc_join_domain user #9040

merged 1 commit into from
Dec 10, 2024

Conversation

robertsweetman
Copy link
Contributor

  • have added delegated control to computer objects in the relevant OU so this should now work for this svc account

@robertsweetman robertsweetman requested review from a team as code owners December 10, 2024 14:00
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Dec 10, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/oasys-national-reporting


Running Trivy in terraform/environments/oasys-national-reporting
2024-12-10T14:03:07Z INFO [vulndb] Need to update DB
2024-12-10T14:03:07Z INFO [vulndb] Downloading vulnerability DB...
2024-12-10T14:03:07Z INFO [vulndb] Downloading artifact... repo="public.ecr.aws/aquasecurity/trivy-db:2"
2024-12-10T14:03:10Z INFO [vulndb] Artifact successfully downloaded repo="public.ecr.aws/aquasecurity/trivy-db:2"
2024-12-10T14:03:10Z INFO [vuln] Vulnerability scanning is enabled
2024-12-10T14:03:10Z INFO [misconfig] Misconfiguration scanning is enabled
2024-12-10T14:03:10Z INFO [misconfig] Need to update the built-in checks
2024-12-10T14:03:10Z INFO [misconfig] Downloading the built-in checks...
160.80 KiB / 160.80 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2024-12-10T14:03:11Z INFO [secret] Secret scanning is enabled
2024-12-10T14:03:11Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-12-10T14:03:11Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.58/docs/scanner/secret#recommendation for faster secret detection
2024-12-10T14:03:13Z INFO [terraform scanner] Scanning root module file_path="."
2024-12-10T14:03:13Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="networking"
2024-12-10T14:03:14Z INFO Number of language-specific files num=0
2024-12-10T14:03:14Z INFO Detected config files num=1
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/oasys-national-reporting

*****************************

Running Checkov in terraform/environments/oasys-national-reporting
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 169, Failed checks: 0, Skipped checks: 26


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/oasys-national-reporting

*****************************

Running tflint in terraform/environments/oasys-national-reporting
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/oasys-national-reporting

*****************************

Running Trivy in terraform/environments/oasys-national-reporting
2024-12-10T14:03:07Z	INFO	[vulndb] Need to update DB
2024-12-10T14:03:07Z	INFO	[vulndb] Downloading vulnerability DB...
2024-12-10T14:03:07Z	INFO	[vulndb] Downloading artifact...	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2024-12-10T14:03:10Z	INFO	[vulndb] Artifact successfully downloaded	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2024-12-10T14:03:10Z	INFO	[vuln] Vulnerability scanning is enabled
2024-12-10T14:03:10Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-12-10T14:03:10Z	INFO	[misconfig] Need to update the built-in checks
2024-12-10T14:03:10Z	INFO	[misconfig] Downloading the built-in checks...
160.80 KiB / 160.80 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2024-12-10T14:03:11Z	INFO	[secret] Secret scanning is enabled
2024-12-10T14:03:11Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-12-10T14:03:11Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.58/docs/scanner/secret#recommendation for faster secret detection
2024-12-10T14:03:13Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-12-10T14:03:13Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="networking"
2024-12-10T14:03:14Z	INFO	Number of language-specific files	num=0
2024-12-10T14:03:14Z	INFO	Detected config files	num=1
trivy_exitcode=0

@robertsweetman robertsweetman merged commit 4146990 into main Dec 10, 2024
16 checks passed
@robertsweetman robertsweetman deleted the TM/onr-pp-fsx-redeploy branch December 10, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants