Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification failure steps by adding webhook-type input for compatibility with slackapi/slack-github-action v2.0.0 #8919

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

richgreen-moj
Copy link
Contributor

Why?

Failure notifications not working on aws nuke jobs e.g. https://github.com/ministryofjustice/modernisation-platform-environments/actions/runs/12105218464/job/33749551976#step:9:29

This has already been fixed for MP workflows here: ministryofjustice/modernisation-platform#8612

What's changed?

Fix notification failure steps by adding webhook-type input for compatibility with slackapi/slack-github-action v2.0.0

@richgreen-moj richgreen-moj requested a review from a team as a code owner December 2, 2024 09:57
@github-actions github-actions bot added environments-repository Used to exclude PRs from this repo in our Slack PR update github-workflow labels Dec 2, 2024
…patibility with `slackapi/slack-github-action` v2.0.0
@richgreen-moj richgreen-moj force-pushed the fix/failure-notification branch from 3ead864 to 673dd39 Compare December 2, 2024 10:03
@richgreen-moj richgreen-moj merged commit bc2519b into main Dec 2, 2024
28 checks passed
@richgreen-moj richgreen-moj deleted the fix/failure-notification branch December 2, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update github-workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants