Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS037 - Role for Sharing into Analytical Platform #7090

Merged

Conversation

julialawrence
Copy link
Contributor

Analytical Platform tracking ticket: ministryofjustice/analytical-platform#4358

This PR adds a role to allow Analytical Platform terraform to share a database and two tables from the Digital Prisons Reporting pre-production account into Analytical Platform Data Production account using resource access manager and LakeFormation.

The scope of the role is controlled via an analytical_platform_share block added in tjhe application_variables.json in the preproduction environment.

The terraform to perform the share is in this module and will be run in the Analytical Platform Data Production account as Modernisation Platform currently has no capacity for assuming of roles in another account outside of the few restricted ones.

@julialawrence julialawrence requested review from a team as code owners July 15, 2024 08:18
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Jul 15, 2024
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-development July 16, 2024 12:44 — with GitHub Actions Error
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-test July 16, 2024 13:14 — with GitHub Actions Error
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-development July 17, 2024 10:43 — with GitHub Actions Error
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-test July 17, 2024 10:43 — with GitHub Actions Error
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-development July 17, 2024 10:52 — with GitHub Actions Error
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-test July 17, 2024 10:52 — with GitHub Actions Error
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-development July 17, 2024 13:01 — with GitHub Actions Error
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-test July 17, 2024 13:01 — with GitHub Actions Error
@julialawrence julialawrence force-pushed the apdpr4358/share-glue-resources-into-analytical-platform branch from aa91a07 to 493bf0a Compare July 17, 2024 16:27
Copy link
Contributor

@dms1981 dms1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this one with Julia via Slack. So long as the @ministryofjustice/hmpps-digital-prison-reporting team are happy with this, there's no problem from our side.

Copy link
Contributor

@harichintala1 harichintala1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julialawrence julialawrence had a problem deploying to digital-prison-reporting-test July 18, 2024 11:36 — with GitHub Actions Error
@julialawrence julialawrence had a problem deploying to digital-prison-reporting-development July 18, 2024 11:36 — with GitHub Actions Error
@julialawrence julialawrence merged commit 8c5e63f into main Jul 18, 2024
11 of 16 checks passed
@julialawrence julialawrence deleted the apdpr4358/share-glue-resources-into-analytical-platform branch July 18, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants