-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EM: Edit step function to include athena log validation #6604
Conversation
|
|
|
|
...aform/environments/electronic-monitoring-data/glue-job/dms_dv_rds_and_s3_parquet_write_v2.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terraform plan evaluation detected changes to resources that require approval from @ministryofjustice/modernsation-platform - please contact #ask-modernisation-platform for assistance
@matt-heery Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terraform plan evaluation detected changes to resources that require approval from @ministryofjustice/modernsation-platform - please contact #ask-modernisation-platform for assistance
@matt-heery Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance |
terraform/environments/electronic-monitoring-data/lambdas/update_log_table/update_log_table.py
Outdated
Show resolved
Hide resolved
terraform/environments/electronic-monitoring-data/lambdas/update_log_table/Makefile
Outdated
Show resolved
Hide resolved
Matt H has run us through all of the changes, it all seems reasonable. A couple of comments that can be fixed in other PRs after this is merged include:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of changes, and in future we will be splitting this up into smaller bite sized chunks to merge a larger PR in later. We reviewed it as a team together but some of the changes appear to ned MOD platform approval. This review should be prioritised over mine.
Currently the step function writes ALL tables to the AP by default.
We want to only write validated tables to the AP. The first step of this step function is to run a query the log tables against all tables in that database bringing back the tables with Validated in their validation message, and trigger all of those.