Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌪️ APC Airflow #6448

Merged
merged 4 commits into from
Jun 6, 2024
Merged

🌪️ APC Airflow #6448

merged 4 commits into from
Jun 6, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Jun 6, 2024 •
edited
Loading

This pull request:

Signed-off-by: Jacob Woffenden [email protected]

Add namespace and role
40a4201 
Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden self-assigned this Jun 6, 2024
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Jun 6, 2024
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-compute-development June 6, 2024 10:24 — with GitHub Actions Inactive
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-compute-test June 6, 2024 10:25 — with GitHub Actions Inactive
Jacob Woffenden added 2 commits June 6, 2024 10:34
Update EFS CSI
2b924b9 
Signed-off-by: Jacob Woffenden <[email protected]>
Update EKS module
ea7924c 
Add access entry for airflow

Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-compute-test June 6, 2024 10:45 — with GitHub Actions Inactive
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-compute-development June 6, 2024 10:45 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

Running Trivy in terraform/environments/analytical-platform-compute
2024-06-06T10:45:37Z INFO Need to update DB
2024-06-06T10:45:37Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-06T10:45:39Z INFO Vulnerability scanning is enabled
2024-06-06T10:45:39Z INFO Misconfiguration scanning is enabled
2024-06-06T10:45:39Z INFO Need to update the built-in policies
2024-06-06T10:45:39Z INFO Downloading the built-in policies...
49.76 KiB / 49.76 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-06T10:45:40Z INFO Secret scanning is enabled
2024-06-06T10:45:40Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-06T10:45:40Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-06T10:45:57Z INFO Number of language-specific files num=0
2024-06-06T10:45:57Z INFO Detected config files num=13

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=098c6a86ca716dae74bd98974accc29f66178c43/main.tf (terraform)

Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-role-for-service-accounts-eks/policies.tf (terraform)

Tests: 22 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 22)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam-policies.tf (terraform)

Tests: 5 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Checkov in terraform/environments/analytical-platform-compute
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-06 10:46:00,625 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,625 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.2.0 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,625 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/secrets-manager/aws:1.1.2 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,625 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:5.8.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,625 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,625 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:5.8.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,626 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:5.1.2 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,626 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws:20.13.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,626 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:3.0.0 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,626 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/route53/aws//modules/zones:2.11.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,626 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 10:46:00,626 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks-pod-identity/aws:1.2.1 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 44, Failed checks: 0, Skipped checks: 52


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running tflint in terraform/environments/analytical-platform-compute
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Trivy in terraform/environments/analytical-platform-compute
2024-06-06T10:45:37Z	INFO	Need to update DB
2024-06-06T10:45:37Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-06T10:45:39Z	INFO	Vulnerability scanning is enabled
2024-06-06T10:45:39Z	INFO	Misconfiguration scanning is enabled
2024-06-06T10:45:39Z	INFO	Need to update the built-in policies
2024-06-06T10:45:39Z	INFO	Downloading the built-in policies...
49.76 KiB / 49.76 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-06T10:45:40Z	INFO	Secret scanning is enabled
2024-06-06T10:45:40Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-06T10:45:40Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-06T10:45:57Z	INFO	Number of language-specific files	num=0
2024-06-06T10:45:57Z	INFO	Detected config files	num=13

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=098c6a86ca716dae74bd98974accc29f66178c43/main.tf (terraform)
===============================================================================================================================
Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-role-for-service-accounts-eks/policies.tf (terraform)
=============================================================================================================================================================================
Tests: 22 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 22)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam-policies.tf (terraform)
===========================
Tests: 5 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

Expand general MNG
ac30a57 
Add airflow-high-memory

Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-compute-test June 6, 2024 11:07 — with GitHub Actions Inactive
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-compute-development June 6, 2024 11:07 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

Running Trivy in terraform/environments/analytical-platform-compute
2024-06-06T11:07:50Z INFO Need to update DB
2024-06-06T11:07:50Z INFO Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-06T11:07:52Z INFO Vulnerability scanning is enabled
2024-06-06T11:07:52Z INFO Misconfiguration scanning is enabled
2024-06-06T11:07:52Z INFO Need to update the built-in policies
2024-06-06T11:07:52Z INFO Downloading the built-in policies...
49.76 KiB / 49.76 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-06T11:07:52Z INFO Secret scanning is enabled
2024-06-06T11:07:52Z INFO If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-06T11:07:52Z INFO Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-06T11:08:07Z INFO Number of language-specific files num=0
2024-06-06T11:08:07Z INFO Detected config files num=13

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=098c6a86ca716dae74bd98974accc29f66178c43/main.tf (terraform)

Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)

git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-role-for-service-accounts-eks/policies.tf (terraform)

Tests: 22 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 22)
Failures: 0 (HIGH: 0, CRITICAL: 0)

iam-policies.tf (terraform)

Tests: 5 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Checkov in terraform/environments/analytical-platform-compute
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-06-06 11:08:10,161 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,161 [MainThread  ] [WARNI]  Failed to download module ministryofjustice/observability-platform-tenant/aws:1.2.0 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,161 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/secrets-manager/aws:1.1.2 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,161 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws//modules/vpc-endpoints:5.8.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,161 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:5.39.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,162 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/vpc/aws:5.8.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,162 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/security-group/aws:5.1.2 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,162 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks/aws:20.13.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,162 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/kms/aws:3.0.0 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,162 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/route53/aws//modules/zones:2.11.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,162 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/cloudwatch/aws//modules/log-group:5.3.1 (for external modules, the --download-external-modules flag is required)
2024-06-06 11:08:10,162 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/eks-pod-identity/aws:1.2.1 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 44, Failed checks: 0, Skipped checks: 52


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running tflint in terraform/environments/analytical-platform-compute
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/analytical-platform-compute

*****************************

Running Trivy in terraform/environments/analytical-platform-compute
2024-06-06T11:07:50Z	INFO	Need to update DB
2024-06-06T11:07:50Z	INFO	Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-06-06T11:07:52Z	INFO	Vulnerability scanning is enabled
2024-06-06T11:07:52Z	INFO	Misconfiguration scanning is enabled
2024-06-06T11:07:52Z	INFO	Need to update the built-in policies
2024-06-06T11:07:52Z	INFO	Downloading the built-in policies...
49.76 KiB / 49.76 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-06-06T11:07:52Z	INFO	Secret scanning is enabled
2024-06-06T11:07:52Z	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-06T11:07:52Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-06T11:08:07Z	INFO	Number of language-specific files	num=0
2024-06-06T11:08:07Z	INFO	Detected config files	num=13

git::https:/github.com/terraform-aws-modules/terraform-aws-eks?ref=098c6a86ca716dae74bd98974accc29f66178c43/main.tf (terraform)
===============================================================================================================================
Tests: 5 (SUCCESSES: 1, FAILURES: 0, EXCEPTIONS: 4)
Failures: 0 (HIGH: 0, CRITICAL: 0)


git::https:/github.com/terraform-aws-modules/terraform-aws-iam?ref=de95e21a3bc51cd3a44b3b95a4c2f61000649ebb/modules/iam-role-for-service-accounts-eks/policies.tf (terraform)
=============================================================================================================================================================================
Tests: 22 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 22)
Failures: 0 (HIGH: 0, CRITICAL: 0)


iam-policies.tf (terraform)
===========================
Tests: 5 (SUCCESSES: 0, FAILURES: 0, EXCEPTIONS: 5)
Failures: 0 (HIGH: 0, CRITICAL: 0)

trivy_exitcode=0

@jacobwoffenden jacobwoffenden marked this pull request as ready for review June 6, 2024 11:17
@jacobwoffenden jacobwoffenden requested review from a team as code owners June 6, 2024 11:17
Gary-H9
Gary-H9 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit 470f440 into main Jun 6, 2024
14 checks passed
@jacobwoffenden jacobwoffenden deleted the feat/apc-airflow branch June 6, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gary-H9 Gary-H9 Gary-H9 approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @Gary-H9