Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Add egress functionality to Analytical Platform Ingestion #5503

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Mar 27, 2024

This pull request:

  • Adds a new module which introduces egress functionality

Signed-off-by: Jacob Woffenden [email protected]

Co-authored-by: Gary <[email protected]>
Signed-off-by: GitHub <[email protected]>
@jacobwoffenden jacobwoffenden self-assigned this Mar 27, 2024
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Mar 27, 2024
@jacobwoffenden jacobwoffenden had a problem deploying to analytical-platform-ingestion-development March 27, 2024 14:58 — with GitHub Actions Failure
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

Signed-off-by: GitHub <[email protected]>
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-ingestion-development March 27, 2024 15:02 — with GitHub Actions Inactive
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

Signed-off-by: GitHub <[email protected]>
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-ingestion-development March 27, 2024 17:09 — with GitHub Actions Inactive
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

formatting

Signed-off-by: GitHub <[email protected]>
@modernisation-platform-ci
Copy link
Contributor

@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

1 similar comment
@modernisation-platform-ci
Copy link
Contributor

@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

Copy link
Contributor

github-actions bot commented Apr 2, 2024

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

sukeshreddyg
sukeshreddyg previously approved these changes Apr 2, 2024
@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-ingestion-development April 2, 2024 13:55 — with GitHub Actions Inactive
Signed-off-by: GitHub <[email protected]>
@modernisation-platform-ci
Copy link
Contributor

@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

@jacobwoffenden jacobwoffenden temporarily deployed to analytical-platform-ingestion-development April 2, 2024 14:15 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Apr 2, 2024

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

@modernisation-platform-ci
Copy link
Contributor

@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

Copy link
Contributor

github-actions bot commented Apr 2, 2024

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

@jacobwoffenden jacobwoffenden marked this pull request as ready for review April 2, 2024 14:43
@jacobwoffenden jacobwoffenden requested review from a team as code owners April 2, 2024 14:43
@modernisation-platform-ci
Copy link
Contributor

@jacobwoffenden Terraform plan evalaution detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform

Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit 4d3d143 into main Apr 2, 2024
16 of 18 checks passed
@jacobwoffenden jacobwoffenden deleted the feature/ap-ingestion-ingress branch April 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants