Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaps: Use private subnet #4499

Merged
merged 11 commits into from
Jan 15, 2024
Merged

Chaps: Use private subnet #4499

merged 11 commits into from
Jan 15, 2024

Conversation

vertism
Copy link
Contributor

@vertism vertism commented Jan 10, 2024

Also installs choco

@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Jan 10, 2024
@vertism vertism temporarily deployed to cdpt-chaps-development January 10, 2024 15:52 — with GitHub Actions Inactive
Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Trivy Scan

Show Output

@vertism vertism temporarily deployed to cdpt-chaps-development January 10, 2024 17:08 — with GitHub Actions Inactive
Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Trivy Scan

Show Output

@vertism vertism changed the title Chaps: Change AMI Chaps: Install Choco Jan 10, 2024
@vertism vertism temporarily deployed to cdpt-chaps-development January 10, 2024 17:28 — with GitHub Actions Inactive
Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Trivy Scan

Show Output

@vertism vertism temporarily deployed to cdpt-chaps-development January 11, 2024 09:22 — with GitHub Actions Inactive
Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Trivy Scan

Show Output

@vertism vertism temporarily deployed to cdpt-chaps-development January 11, 2024 12:03 — with GitHub Actions Inactive
Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Trivy Scan

Show Output

@vertism vertism had a problem deploying to cdpt-chaps-development January 11, 2024 13:40 — with GitHub Actions Failure
Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Trivy Scan

Show Output

@vertism vertism had a problem deploying to cdpt-chaps-development January 11, 2024 13:48 — with GitHub Actions Failure
Copy link
Contributor

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Trivy Scan

Show Output

@vertism vertism had a problem deploying to cdpt-chaps-development January 15, 2024 10:34 — with GitHub Actions Failure
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:

Trivy Scan

Show Output

@vertism vertism changed the title Chaps: Install Choco Chaps: Use private subnet Jan 15, 2024
@vertism vertism had a problem deploying to cdpt-chaps-development January 15, 2024 11:59 — with GitHub Actions Failure
Copy link
Contributor

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:
terraform/environments/nomis-data-hub


Running TFSEC in terraform/environments/nomis-data-hub
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 1.416056ms
parsing 167.314607ms
adaptation 126.486µs
checks 3.636292ms
total 172.493441ms

counts
──────────────────────────────────────────
modules downloaded 0
modules processed 5
blocks processed 269
files read 71

results
──────────────────────────────────────────
passed 1
ignored 0
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/nomis-data-hub

*****************************

Running Checkov in terraform/environments/nomis-data-hub
terraform scan results:

Passed checks: 90, Failed checks: 0, Skipped checks: 19


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/nomis-data-hub

*****************************

Running tflint in terraform/environments/nomis-data-hub
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan

Show Output

@vertism vertism temporarily deployed to cdpt-chaps-development January 15, 2024 12:09 — with GitHub Actions Inactive
@vertism vertism marked this pull request as ready for review January 15, 2024 12:16
@vertism vertism requested review from a team as code owners January 15, 2024 12:16
@vertism vertism had a problem deploying to cdpt-chaps-development January 15, 2024 12:17 — with GitHub Actions Failure
@vertism vertism merged commit aec9ca3 into main Jan 15, 2024
26 of 30 checks passed
@vertism vertism deleted the chaps-ami-change branch January 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants