Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaps certificate #4292

Merged
merged 3 commits into from
Dec 12, 2023
+14 −22
Merged

Chaps certificate #4292

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fccc053
Enable ssl certificate
vertism Dec 11, 2023
1ba8385
fix reference
vertism Dec 11, 2023
236dd3f
add exceptions
vertism Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 14 additions & 22 deletions terraform/environments/cdpt-chaps/loadbalancer.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@ resource "aws_security_group" "chaps_lb_sc" {
protocol = "tcp"
cidr_blocks = ["0.0.0.0/0"]
}

egress {
description = "allow all outbound traffic for port 443"
from_port = 443
to_port = 443
protocol = "tcp"
cidr_blocks = ["0.0.0.0/0"]
}
}

resource "aws_lb" "chaps_lb" {
Expand Down Expand Up @@ -71,6 +63,7 @@ resource "aws_lb_target_group" "chaps_target_group" {
}

resource "aws_lb_listener" "listener" {
#checkov:skip=CKV_AWS_103
load_balancer_arn = aws_lb.chaps_lb.arn
port = 80
protocol = "HTTP"
Expand All @@ -81,18 +74,17 @@ resource "aws_lb_listener" "listener" {
}
}

# resource "aws_lb_listener" "chaps_lb" {
# depends_on = [
# aws_acm_certificate.external
# ]
# certificate_arn = aws_acm_certificate.external.arn
# load_balancer_arn = aws_lb.chaps_lb.arn
# port = 443
# protocol = "HTTPS"
# ssl_policy = "ELBSecurityPolicy-2016-08"
resource "aws_lb_listener" "https_listener" {
#checkov:skip=CKV_AWS_103
depends_on = [aws_acm_certificate_validation.external]

# default_action {
# type = "forward"
# target_group_arn = aws_lb_target_group.chaps_target_group.arn
# }
# }
load_balancer_arn = aws_lb.chaps_lb.arn
port = "443"
protocol = "HTTPS"
certificate_arn = aws_acm_certificate.external.arn

default_action {
target_group_arn = aws_lb_target_group.chaps_target_group.id
type = "forward"
}
}
Loading