Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PECS secrets #4248

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Remove PECS secrets #4248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions terraform/environments/performance-hub/data.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ data "template_file" "task_definition" {
storage_bucket = "${aws_s3_bucket.upload_files.id}"
friendly_name = local.app_data.accounts[local.environment].friendly_name
hub_wwwroot = local.app_data.accounts[local.environment].hub_wwwroot
pecs_basm_prod_access_key_id = aws_secretsmanager_secret_version.pecs_basm_prod_access_key_id.arn
pecs_basm_prod_secret_access_key = aws_secretsmanager_secret_version.pecs_basm_prod_secret_access_key.arn
ap_import_access_key_id = aws_secretsmanager_secret_version.ap_import_access_key_id.arn
ap_import_secret_access_key = aws_secretsmanager_secret_version.ap_import_secret_access_key.arn
ap_export_access_key_id = aws_secretsmanager_secret_version.ap_export_access_key_id.arn
Expand Down
34 changes: 0 additions & 34 deletions terraform/environments/performance-hub/secrets.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,40 +140,6 @@ resource "aws_secretsmanager_secret_version" "ap_export_secret_access_key" {
secret_string = random_password.random_password.result
}

#tfsec:ignore:AWS095
resource "aws_secretsmanager_secret" "pecs_basm_prod_access_key_id" {
#checkov:skip=CKV_AWS_149
name = "pecs_basm_prod_access_key_id"
recovery_window_in_days = 0
tags = merge(
local.tags,
{
Name = "pecs_basm_prod_access_key_id"
},
)
}
resource "aws_secretsmanager_secret_version" "pecs_basm_prod_access_key_id" {
secret_id = aws_secretsmanager_secret.pecs_basm_prod_access_key_id.id
secret_string = random_password.random_password.result
}

#tfsec:ignore:AWS095
resource "aws_secretsmanager_secret" "pecs_basm_prod_secret_access_key" {
#checkov:skip=CKV_AWS_149
name = "pecs_basm_prod_secret_access_key"
recovery_window_in_days = 0
tags = merge(
local.tags,
{
Name = "pecs_basm_prod_secret_access_key"
},
)
}
resource "aws_secretsmanager_secret_version" "pecs_basm_prod_secret_access_key" {
secret_id = aws_secretsmanager_secret.pecs_basm_prod_secret_access_key.id
secret_string = random_password.random_password.result
}

#tfsec:ignore:AWS095
resource "aws_secretsmanager_secret" "db_password" {
#checkov:skip=CKV_AWS_149
Expand Down